Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UserContactInfo admin improvements #9300

Closed
wants to merge 1 commit into from

Conversation

tomaszn
Copy link
Contributor

@tomaszn tomaszn commented Jan 8, 2024

User's contact details can change, and the administrator should be able to edit them.

Currently, picking the right object to edit is difficult:

image

This PR configures Django Admin to display a table with the values:

image

Copy link

dryrunsecurity bot commented Jan 8, 2024

Contextual Security Analysis

As DryRun Security performs checks, we’ll summarize them here. You can always dive into the detailed results in the section below for checks.

Status DryRun Security Check
AI-powered Sensitive Function Check
Configured Sensitive Files Check
AI-powered Sensitive Files Check

Chat with your AI-powered Security Buddy by typing @dryrunsecurity followed by your question into a comment.
Example: @dryrunsecurity What are common security issues with web application cookies?

Install and configure more repositories at DryRun Security

@tomaszn
Copy link
Contributor Author

tomaszn commented Jan 16, 2024

@cneill Please review if possible

@mtesauro
Copy link
Contributor

We had a conversation about the Django Admin in the last moderators meeting and since it doesn't enforce constraints for data changes, using it is a great way to corrupt your data. This is why we don't enable it in our deploys.

We don't want to take any more PR against the Django admin and give the community the impression we are actively supporting that use case.

@devGregA devGregA closed this Jan 16, 2024
@devGregA
Copy link
Contributor

+1 What Matt says, but thank you for the PR. User data can be edited via the "User" management tabs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants