Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django Admin: fix creating new notifications #9341

Closed

Conversation

tomaszn
Copy link
Contributor

@tomaszn tomaszn commented Jan 16, 2024

This is a fix for #9340. It enables User and Product fields in Add notifications editor in Django Admin interface, so new notifications can be set up for any Product and User combination.

Test results

Tested manually. Screenshot:

sc

Copy link

dryrunsecurity bot commented Jan 16, 2024

Contextual Security Analysis

As DryRun Security performs checks, we’ll summarize them here. You can always dive into the detailed results in the section below for checks.

Status DryRun Security Check
AI-powered Sensitive Function Check
Configured Sensitive Files Check
AI-powered Sensitive Files Check

Chat with your AI-powered Security Buddy by typing @dryrunsecurity followed by your question into a comment.
Example: @dryrunsecurity What are common security issues with web application cookies?

Install and configure more repositories at DryRun Security

@github-actions github-actions bot added the New Migration Adding a new migration file. Take care when merging. label Jan 16, 2024
@devGregA
Copy link
Contributor

Hi @tomaszn, is it possible to incorporate these changes into notfications rather than admin? We're trying to keep people away from django admin for data integrity purposes.

@tomaszn
Copy link
Contributor Author

tomaszn commented Jan 16, 2024

@devGregA, I fully understand your concern about data integrity. On the other hand, the alternative for now is editing the database records.

I can imagine such a rework of the View User page. Maybe two new sections, one for user's general notification settings, and another for per-product notifications. Plus a nice wizard that sets up notifications for all products that match some criteria like tags or Product Type. This could be also accessible for regular users to set up and review their notifications.

But that would be a bigger feature. As the code freeze is in progress, what do you think about tackling it after DefectDojo 3.0 is released, and proceeding with this for now?

(Dropping per #9300 (comment). Django Admin features will be published in my fork.)

@tomaszn tomaszn closed this Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Migration Adding a new migration file. Take care when merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants