Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JMXFetch telemetry around bean/attribute matching #487

Merged
merged 8 commits into from
Nov 10, 2023
Merged

Add JMXFetch telemetry around bean/attribute matching #487

merged 8 commits into from
Nov 10, 2023

Conversation

rayz
Copy link
Contributor

@rayz rayz commented Oct 17, 2023 •
edited
Loading

these changes:

  1. add telemetry for the ratio of beans that had at least one attribute match
  2. add telemetry for # of wildcard bean queries

additional notes:
a following pr in the datadog-agent repo is needed to display these stats onto the datadog-agent status -v output

@rayz rayz force-pushed the raymond.zhao/AMLII-1141-bean-attribute-instance-telemetry branch 4 times, most recently from 992c29d to 3e63966 Compare October 18, 2023 19:39
@rayz rayz changed the title [draft] add bean attribute instance stats Add JMXFetch telemetry around bean/attribute matching Oct 18, 2023
@rayz rayz marked this pull request as ready for review October 18, 2023 19:58
@rayz rayz requested a review from a team as a code owner October 18, 2023 19:58
@rayz rayz force-pushed the raymond.zhao/AMLII-1141-bean-attribute-instance-telemetry branch from 3e63966 to b9671c3 Compare October 24, 2023 15:38
scottopell
scottopell suggested changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@scottopell scottopell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some naming suggestions and clarifying questions, but this looks good overall

src/main/java/org/datadog/jmxfetch/util/InstanceTelemetry.java Outdated Show resolved Hide resolved
src/main/java/org/datadog/jmxfetch/util/InstanceTelemetry.java Outdated Show resolved Hide resolved
src/main/java/org/datadog/jmxfetch/Instance.java Show resolved Hide resolved
src/main/java/org/datadog/jmxfetch/Instance.java Outdated Show resolved Hide resolved
src/main/java/org/datadog/jmxfetch/Instance.java Outdated Show resolved Hide resolved
scottopell
scottopell suggested changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@scottopell scottopell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After discussion, the number of domains queried is not straightforward to instrument. Lets not collect it as telemetry.

@scottopell scottopell merged commit 33e7e94 into master Nov 10, 2023
2 checks passed
@rayz rayz mentioned this pull request Nov 10, 2023
Merged
10 tasks
scottopell added a commit that referenced this pull request Dec 27, 2023
@scottopell
Relands bean match ratio from #487
be3c9b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottopell scottopell scottopell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rayz @scottopell