Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JMX wildcard_domain_query_count and bean_match_ratio to agent status #20801

Merged

Conversation

rayz
Copy link
Contributor

@rayz rayz commented Nov 10, 2023

What does this PR do?

Displays instance_wildcard_domain_query_count and instance_bean_match_ratio under JMXFetch when agent status -v is run.
image

Motivation

Display telemetry for bean/attribute matching

Additional Notes

Related to DataDog/jmxfetch#487

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

Run agent status -v with jmx instance running and observe the output.

Reviewer's Checklist

  • If known, an appropriate milestone has been selected; otherwise the Triage milestone is set.
  • Use the major_change label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.
  • A release note has been added or the changelog/no-changelog label has been applied.
  • Changed code has automated tests for its functionality.
  • Adequate QA/testing plan information is provided if the qa/skip-qa label is not applied.
  • At least one team/.. label has been applied, indicating the team(s) that should QA this change.
  • If applicable, docs team has been notified or an issue has been opened on the documentation repo.
  • If applicable, the need-change/operator and need-change/helm labels have been applied.
  • If applicable, the k8s/<min-version> label, indicating the lowest Kubernetes version compatible with this feature.
  • If applicable, the config template has been updated.

@rayz rayz added this to the 7.50.0 milestone Nov 10, 2023
@rayz rayz requested a review from a team as a code owner November 10, 2023 19:27
@rayz rayz merged commit f0e30ee into main Nov 10, 2023
16 of 20 checks passed
@rayz rayz deleted the raymond.zhao/AMLII-1141-bean-attribute-instance-telemetry-status branch November 10, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants