Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move appraisal gem to dev group #4200

Merged
merged 2 commits into from
Dec 6, 2024
Merged

Conversation

TonyCTHsu
Copy link
Contributor

@TonyCTHsu TonyCTHsu commented Dec 6, 2024

Motivation:

Reduce gemfile size

What does this PR do?

  1. Move appraisal gem to dev group to be removed from testing dependencies
  2. Remove obsolete Appraisals and rake tasks

Change log entry

None

@TonyCTHsu TonyCTHsu added the dev/tooling Involves tools (e.g. Rubocop, CodeCov) label Dec 6, 2024
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner December 6, 2024 15:15
@pr-commenter
Copy link

pr-commenter bot commented Dec 6, 2024

Benchmarks

Benchmark execution time: 2024-12-06 15:48:21

Comparing candidate commit ed76dcb in PR branch tonycthsu/appraisal-reduce with baseline commit 507fe0a in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.76%. Comparing base (507fe0a) to head (ed76dcb).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4200      +/-   ##
==========================================
- Coverage   97.77%   97.76%   -0.01%     
==========================================
  Files        1357     1357              
  Lines       81940    81940              
  Branches     4168     4168              
==========================================
- Hits        80114    80110       -4     
- Misses       1826     1830       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TonyCTHsu TonyCTHsu enabled auto-merge December 6, 2024 16:01
Copy link
Member

@Strech Strech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More 🟥 than 🟢
Awesome 👏🏼

@TonyCTHsu TonyCTHsu merged commit 9875835 into master Dec 6, 2024
351 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/appraisal-reduce branch December 6, 2024 16:03
@github-actions github-actions bot added this to the 2.8.0 milestone Dec 6, 2024
@TonyCTHsu TonyCTHsu mentioned this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/tooling Involves tools (e.g. Rubocop, CodeCov)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants