Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move appraisal for 3.3 #4201

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Move appraisal for 3.3 #4201

merged 1 commit into from
Dec 6, 2024

Conversation

TonyCTHsu
Copy link
Contributor

What does this PR do?
Move appraisal for 3.3

Motivation:
Leftover from #4200

Change log entry
None

@TonyCTHsu TonyCTHsu added the dev/tooling Involves tools (e.g. Rubocop, CodeCov) label Dec 6, 2024
@TonyCTHsu TonyCTHsu requested a review from a team as a code owner December 6, 2024 18:33
@TonyCTHsu TonyCTHsu enabled auto-merge December 6, 2024 18:34
Copy link
Contributor

@sarahchen6 sarahchen6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.76%. Comparing base (9875835) to head (6985d05).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4201      +/-   ##
==========================================
- Coverage   97.76%   97.76%   -0.01%     
==========================================
  Files        1357     1357              
  Lines       81941    81940       -1     
  Branches     4168     4168              
==========================================
- Hits        80107    80105       -2     
- Misses       1834     1835       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Dec 6, 2024

Benchmarks

Benchmark execution time: 2024-12-06 18:55:59

Comparing candidate commit 6985d05 in PR branch tonycthsu/move-aaproisal with baseline commit 9875835 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@TonyCTHsu TonyCTHsu merged commit b47a0ff into master Dec 6, 2024
346 checks passed
@TonyCTHsu TonyCTHsu deleted the tonycthsu/move-aaproisal branch December 6, 2024 18:57
@github-actions github-actions bot added this to the 2.8.0 milestone Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/tooling Involves tools (e.g. Rubocop, CodeCov)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants