Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in override of coordination directory #5153

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

gmloose
Copy link
Contributor

@gmloose gmloose commented Nov 12, 2024

The override of the coordination directory that a user could make was not applied correctly. Instead of setting self.coordination_dir the variable self.workDir would be modified. This has been fixed.

Changelog Entry

To be copied to the draft changelog by merger:

  • PR submitter writes their recommendation for a changelog entry here

Reviewer Checklist

  • Make sure it is coming from issues/XXXX-fix-the-thing in the Toil repo, or from an external repo.
    • If it is coming from an external repo, make sure to pull it in for CI with:
      contrib/admin/test-pr otheruser theirbranchname issues/XXXX-fix-the-thing
      
    • If there is no associated issue, create one.
  • Read through the code changes. Make sure that it doesn't have:
    • Addition of trailing whitespace.
    • New variable or member names in camelCase that want to be in snake_case.
    • New functions without type hints.
    • New functions or classes without informative docstrings.
    • Changes to semantics not reflected in the relevant docstrings.
    • New or changed command line options for Toil workflows that are not reflected in docs/running/{cliOptions,cwl,wdl}.rst
    • New features without tests.
  • Comment on the lines of code where problems exist with a review comment. You can shift-click the line numbers in the diff to select multiple lines.
  • Finish the review with an overall description of your opinion.

Merger Checklist

  • Make sure the PR passes tests.
  • Make sure the PR has been reviewed since its last modification. If not, review it.
  • Merge with the Github "Squash and merge" feature.
    • If there are multiple authors' commits, add Co-authored-by to give credit to all contributing authors.
  • Copy its recommended changelog entry to the Draft Changelog.
  • Append the issue number in parentheses to the changelog entry.

The override of the coordination directory that a user could make was not applied correctly. Instead of setting `self.coordination_dir` the variable `self.workDir` would be modified. This has been fixed.
@gmloose gmloose changed the title Fix bug in override of coordination direction Fix bug in override of coordination directory Nov 12, 2024
@stxue1 stxue1 linked an issue Nov 15, 2024 that may be closed by this pull request
@stxue1 stxue1 enabled auto-merge (squash) November 15, 2024 00:48
@adamnovak
Copy link
Member

I'm not going to bother waiting for a re-test on this, I'm just going to merge it.

@adamnovak
Copy link
Member

Actually we haven't ever had this pass full CI, so we probably should wait for that at least once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in overriding coordination_dir in toil/common.py
3 participants