ec/system76/ec/system76_ec.c: Rework EC FW sync #577
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miczyg1
force-pushed
the
ec_fw_sync_fix
branch
2 times, most recently
from
4afe654
to
085a4b0
Compare
miczyg1
force-pushed
the
ec_fw_sync_fix
branch
from
afd49da
to
7456c66
Compare
miczyg1
changed the title
|
@mkopec it seems to work now. Made a few update attempts in a row and none failed with AAI programming. Though I tested only a couple unused sectors... When I will be at office, I can test full flash update, but to be safe I would like to have a EC kit at hand. You may already test it on your end. No EC FW changes introduced. |
|
I've been flashing back & forth between v0.9.0-rc10 and final with no issues so far 👍 |
mkopec
reviewed
Nov 12, 2024
|
I also think we may want to load the EC update file uncodnitionally, to make the TPM measurements consistent between AC and DC, but that doesn't need to go in this PR |
mkopec
force-pushed
the
mtl-h-dgpu
branch
4 times, most recently
from
9b25a46
to
0678fea
Compare
miczyg1
force-pushed
the
ec_fw_sync_fix
branch
from
7456c66
to
2d4897f
Compare
mkopec
previously approved these changes
Dec 3, 2024
Make theupdate process more reliable and limit the flash operations to sector that actually need it. Also fix the AAi WP operation which sometimes got interrupted after first 2 bytes. Signed-off-by: Michał Żygowski <[email protected]>
Signed-off-by: Michał Żygowski <[email protected]>
Fix incorrect native function of PCH UART0 pads. Signed-off-by: Michał Żygowski <[email protected]>
mkopec
force-pushed
the
ec_fw_sync_fix
branch
from
2d4897f
to
1375f4f
Compare
This reverts commit 0678fea. Signed-off-by: Michał Kopeć <[email protected]>
This reverts commit 6c7f0f6. Signed-off-by: Michał Kopeć <[email protected]>
mkopec
force-pushed
the
ec_fw_sync_fix
branch
2 times, most recently
from
34f6dd4
to
55a896a
Compare
Signed-off-by: Michał Kopeć <[email protected]>
mkopec
force-pushed
the
ec_fw_sync_fix
branch
from
55a896a
to
9385f24
Compare
mkopec
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.