Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Big address component update #1180

Merged
merged 7 commits into from
Nov 21, 2024
Merged

Big address component update #1180

merged 7 commits into from
Nov 21, 2024

Conversation

jubalm
Copy link
Collaborator

@jubalm jubalm commented Nov 1, 2024

Replace big address component

Screenshot 2024-11-05 at 3 25 53 PM Screenshot 2024-11-05 at 3 26 07 PM
preserve functions interchangeable actions (copy/edit)

@jubalm jubalm force-pushed the big-address-update branch from cbf4d8b to 5eff891 Compare November 5, 2024 07:24
@jubalm jubalm marked this pull request as ready for review November 5, 2024 07:29
Base automatically changed from address-ui-for-coin to main November 5, 2024 12:07
Copy link
Contributor

@KillariDev KillariDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

when changing active address it doesn't highlight the whole button as blue anymore. I guess this is because there's a background color that was not there before?

app/ts/components/subcomponents/address.tsx Outdated Show resolved Hide resolved
app/ts/components/subcomponents/address.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@KillariDev KillariDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but this active address selector looks ugly as the whole button doesn't highlight, there's also copy buttons there that do not work (it just selects the address and copy doesnt actually copy)
image

@jubalm jubalm mentioned this pull request Nov 12, 2024
4 tasks
@KillariDev KillariDev self-requested a review November 21, 2024 08:06
app/ts/components/subcomponents/address.tsx Outdated Show resolved Hide resolved
@KillariDev KillariDev merged commit 0406fad into main Nov 21, 2024
1 check passed
@KillariDev KillariDev deleted the big-address-update branch November 21, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants