Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address BigAddress UI issues #1190

Merged
merged 6 commits into from
Nov 25, 2024
Merged

Address BigAddress UI issues #1190

merged 6 commits into from
Nov 25, 2024

Conversation

jubalm
Copy link
Collaborator

@jubalm jubalm commented Nov 12, 2024 •
edited
Loading

#1180 introduced some issues that this PR resolves

  • remove bigaddress background overlap when nested in a button
  • add disable copy when clicking icon
  • cursor and component flickering when hovering over address without copy action
  • change default card action to undefined instead of copy

@jubalm jubalm marked this pull request as ready for review November 12, 2024 16:33
Base automatically changed from big-address-update to main November 21, 2024 09:38
KillariDev
KillariDev approved these changes Nov 21, 2024
View reviewed changes
app/ts/components/subcomponents/MultilineCard.tsx Outdated Show resolved Hide resolved
app/ts/components/subcomponents/MultilineCard.tsx Outdated Show resolved Hide resolved
app/ts/components/subcomponents/MultilineCard.tsx Outdated Show resolved Hide resolved
app/ts/components/subcomponents/MultilineCard.tsx Outdated Show resolved Hide resolved
app/ts/components/subcomponents/address.tsx Outdated Show resolved Hide resolved
app/ts/components/subcomponents/MultilineCard.tsx Outdated Show resolved Hide resolved
@KillariDev KillariDev merged commit 967b99c into main Nov 25, 2024
1 check passed
@KillariDev KillariDev deleted the big-address-optional-actions branch November 25, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KillariDev KillariDev KillariDev approved these changes

@MicahZoltu MicahZoltu Awaiting requested review from MicahZoltu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jubalm @KillariDev