bugfix: changed externals output arcive diretory permissions to docke…

Makefile

@@ -75,6 +75,10 @@ test: set_env ## run libadore unit tests
 build_external: ## builds all libadore external libraries 
 	cd "${ROOT_DIR}/libadore/external/" && make
 
+.PHONY: clean_external_cache 
+clean_external_cache: ## clean all libadore external library cache located in /var/tmp. Note: This is never done automatically and must be manually invoked.
+	cd "${ROOT_DIR}/libadore/external/" && make clean_cache
+
 .PHONY: clean_external 
 clean_external: ## clean all libadore external libraries
 	cd "${ROOT_DIR}/libadore/external/" && make clean

README.md

@@ -122,8 +122,15 @@ you would like to build in the `.gitmodules` file.
 > by modifying the `.gitmodules` and invoking 'git submodue update --init'.
 
 > **ℹ️ INFO:**
-> By default external libraries are not built. They are sourced as pre-compiled
-> docker images from docker.io.
+> By default external libraries are not built. They are sourced first from local
+> cache in /var/tmp/docker and seconds as pre-compiled docker images from docker.io.
+
+The external libraries cache is not deleted or cleaned automatically. In order
+to clean the external libriary cache located in `/var/tmp/docker` invoke the 
+provided target:
+```bash
+make clean_external_cache
+```
 
 ## License
 The source code and the accompanying material is licensed under the terms of the [EPL v2](https://www.eclipse.org/legal/epl-2.0/).

libadore.mk

@@ -54,6 +54,10 @@ test_libadore: ## run libadore unit tests
 clean_libadore: ## Clean libadore build artifacts
 	cd "${LIBADORE_MAKEFILE_PATH}" && make clean
 
+.PHONY: clean_external_library_cache
+clean_external_library_cache: ## Clean/delete libadore system wide cache in /var/tmp/docker. Note: this is never done automatically and must be manually invoked. 
+	cd "${LIBADORE_MAKEFILE_PATH}" && make clean_external_library_cache
+
 .PHONY: branch_libadore
 branch_libadore: ## Returns the current docker safe/sanitized branch for libadore
 	@printf "%s\n" ${LIBADORE_TAG}

libadore/external/Makefile

@@ -32,11 +32,14 @@ CSAPS_CPP_TAG=${CSAPS_CPP_PROJECT}:${CSAPS_CPP_VERSION}
 
 DOCKER_REPOSITORY=andrewkoerner/adore
 
-EXTERNALS_DOCKER_ARCHIVE="/var/tmp/libadore_externals.tar"
+EXTERNALS_DOCKER_DIRECTORY=/var/tmp/docker
+EXTERNALS_DOCKER_ARCHIVE=${EXTERNALS_DOCKER_DIRECTORY}/libadore_externals.tar
 
 .PHONY: save_docker_images
 save_docker_images:
-	@docker save -o "${EXTERNALS_DOCKER_ARCHIVE}" "${QPOASES_TAG}" "${DLIB_TAG}" "${CATCH2_TAG}" "${OSQP_TAG}" "${XODR_TAG}"
+	@mkdir -p ${EXTERNALS_DOCKER_DIRECTORY} && \
+    docker save -o "${EXTERNALS_DOCKER_ARCHIVE}" "${QPOASES_TAG}" "${DLIB_TAG}" "${CATCH2_TAG}" "${OSQP_TAG}" "${XODR_TAG}" && \
+    chgrp -R docker ${EXTERNALS_DOCKER_DIRECTORY} && chmod -R 2775 ${EXTERNALS_DOCKER_DIRECTORY} || true
 
 .PHONY: load_docker_images
 load_docker_images:
@@ -159,6 +162,11 @@ clean:
 	(cd csaps-cpp && make clean) 2>/dev/null || true 
 	(cd xodr && make clean) 2>/dev/null || true 
 
+.PHONY: clean_cache
+clean_cache: 
+	rm "${EXTERNALS_DOCKER_ARCHIVE}" 2> /dev/null || true
+
+
 .PHONY: docker_publish
 docker_publish:
 	docker tag "${QPOASES_TAG}" "${DOCKER_REPOSITORY}:${QPOASES_PROJECT}_${QPOASES_VERSION}"

libadore/external/README.md

@@ -19,8 +19,15 @@ you would like to build in the `.gitmodules` file.
 
 > **ℹ️ INFO:**
 > By default external libraries are not built. They are sourced as pre-compiled
-> docker images from docker.io. 
+> docker images from docker.io and saved to a local system wide cache in
+> /var/tmp. 
 
+The external libraries cache is not deleted or cleaned automatically. In order
+to clean the external library cache located in `/var/tmp/docker` invoke the 
+provided target:
+```bash
+make clean_cache
+```
 ## Getting Started
 Docker and Make are required