Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: changed externals output arcive diretory permissions to docke… #2

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

akoerner1
Copy link
Contributor

@akoerner1 akoerner1 commented Sep 20, 2023

In order to save bandwidth and docker API calls and under normal circumstances the libadore/externals libraries/submodules are not populated or built. On first build of libadore each externals build context is pulled from docker and saved to /var/tmp. On subsequent builds the docker context is loaded from /var/tmp/docker to prevent repeated docker api calls.

This PR fixes a bug where one user pulls the images and saves them to /var/tmp/docker and another user tries to access them.
The directory /var/tmp/docker is created on first-ever build of libadore on the system and the permissions are set to the group docker. Any member of the docker group can then subsequently read and write to /var/tmp/docker

This is documented in the readme as part of the PR, as well as, an explicit make target was added to advertise this cache and provide a means to delete/clean it.

make help
Usage: make <target>
clean_external_library_cache             Clean/delete libadore system wide cache in /var/tmp/docker. Note: this is never done automatically and must be manually invoked.

@akoerner1 akoerner1 requested a review from tlobig September 20, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant