bugfix: changed externals output arcive diretory permissions to docke… #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to save bandwidth and docker API calls and under normal circumstances the libadore/externals libraries/submodules are not populated or built. On first build of libadore each externals build context is pulled from docker and saved to /var/tmp. On subsequent builds the docker context is loaded from
/var/tmp/docker
to prevent repeated docker api calls.This PR fixes a bug where one user pulls the images and saves them to
/var/tmp/docker
and another user tries to access them.The directory
/var/tmp/docker
is created on first-ever build of libadore on the system and the permissions are set to the groupdocker
. Any member of the docker group can then subsequently read and write to/var/tmp/docker
This is documented in the readme as part of the PR, as well as, an explicit make target was added to advertise this cache and provide a means to delete/clean it.