Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc updates #652

Merged
merged 2 commits into from
Sep 8, 2023
Merged

misc updates #652

merged 2 commits into from
Sep 8, 2023

Conversation

ab9rf
Copy link
Member

@ab9rf ab9rf commented Sep 8, 2023

  • identify an unknown field in item_eggst
  • add a bitfield for pathfinding flags, based mainly on @quietust's 40d research; this is mostly used only internally but it is exposed to structures in unitst
  • (added) remove two fields from work_detail which are apparently padding per comments from putnam

* identify an unknown field in `item_eggst`
* add a bitfield for pathfinding flags, based mainly on @quietust's 40d research; this is mostly used only internally but it is exposed to structures in `unitst`

Co-Authored-By: Quietust <[email protected]>
@ab9rf ab9rf linked an issue Sep 8, 2023 that may be closed by this pull request
Copy link
Member

@myk002 myk002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs changelog, otherwise lgtm

@ab9rf
Copy link
Member Author

ab9rf commented Sep 8, 2023

the eggst change is trivial and the other is mostly internal, not sure a changelog is warranted as neither has consumer-facing impact, we generally don't changelog for changes that have no impact on consumer-facing code

per putnam, these are both padding
@myk002 myk002 merged commit e2e3692 into DFHack:master Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

pathfinding flags - unitst::status2::add_path_flags
2 participants