Merge pull request #3191 from DFE-Digital/LUPEYALPHA-1028/payroll_cop…

…y_update Update payroll details copy
DFE-Digital · Sep 18, 2024 · 043d43e · 043d43e
2 parents e37194c + 69bbf33
commit 043d43e
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 10 deletions.
diff --git a/app/views/admin/tasks/payroll_details.html.erb b/app/views/admin/tasks/payroll_details.html.erb
@@ -48,7 +48,11 @@
           <fieldset class="govuk-fieldset govuk-!-margin-bottom-6">
             <legend class="govuk-fieldset__legend govuk-fieldset__legend--l ">
               <h3 class="govuk-heading-m">
-                <%= I18n.t("#{@claim.policy.to_s.underscore}.admin.task_questions.payroll_details.title", bank_or_building_society: I18n.t("admin.#{@claim.bank_or_building_society}")) %>
+                <%= I18n.t(
+                  "admin.tasks.payroll_details.question",
+                  bank_or_building_society: I18n.t("admin.#{@claim.bank_or_building_society}"),
+                  claimant_name: @claim.full_name
+                ) %>
               </h3>
             </legend>
 

diff --git a/config/locales/en.yml b/config/locales/en.yml
@@ -154,6 +154,7 @@ en:
         title: "Check student loan plan"
       payroll_details:
         title: "Check bank/building society account details"
+        question: "%{claimant_name}'s %{bank_or_building_society} details have not been automatically validated. Has %{claimant_name} confirmed their %{bank_or_building_society} details?"
       census_subjects_taught:
         title: "Check eligible subjects are taught"
       visa:
@@ -430,10 +431,6 @@ en:
           title: "Does the claimant’s student loan amount and plan type match the information we hold about their loan?"
         matching_details:
           title: "Is this claim still valid despite having matching details with other claims?"
-        payroll_details:
-          title:
-            "The claimant’s %{bank_or_building_society} details have not been automatically validated. Has the claimant
-            confirmed their %{bank_or_building_society} details?"
   additional_payments: &additional_payments
     forms:
       correct_school:
@@ -673,10 +670,6 @@ en:
           title: Does the claimant's subject match the schools workforce census subjects
         matching_details:
           title: "Is this claim still valid despite having matching details with other claims?"
-        payroll_details:
-          title:
-            "The claimant’s %{bank_or_building_society} details have not been automatically validated. Has the claimant
-            confirmed their %{bank_or_building_society} details?"
     reminders:
       full_name: Full name
     information_provided_further_details: For more details, you can read about payments and deductions for the %{link}

diff --git a/spec/features/admin/admin_claim_payroll_details_task_spec.rb b/spec/features/admin/admin_claim_payroll_details_task_spec.rb
@@ -33,7 +33,11 @@
 
       click_on I18n.t("admin.tasks.payroll_details.title")
 
-      expect(page).to have_content I18n.t("student_loans.admin.task_questions.payroll_details.title", bank_or_building_society: I18n.t("admin.#{claim.bank_or_building_society}"))
+      expect(page).to have_content I18n.t(
+        "admin.tasks.payroll_details.question",
+        bank_or_building_society: I18n.t("admin.#{claim.bank_or_building_society}"),
+        claimant_name: claim.full_name
+      )
 
       # Can't match entire payload due to whitespace mismatch
       claim.hmrc_bank_validation_responses.each do |response|