Skip to content

Commit

Permalink
Remove duplicated question
Browse files Browse the repository at this point in the history
This question is the same for all policies so move it to the top level
admin namespace
  • Loading branch information
rjlynch committed Sep 18, 2024
1 parent a51ce16 commit 69bbf33
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 6 deletions.
2 changes: 1 addition & 1 deletion app/views/admin/tasks/payroll_details.html.erb
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
<legend class="govuk-fieldset__legend govuk-fieldset__legend--l ">
<h3 class="govuk-heading-m">
<%= I18n.t(
"#{@claim.policy.to_s.underscore}.admin.task_questions.payroll_details.title",
"admin.tasks.payroll_details.question",
bank_or_building_society: I18n.t("admin.#{@claim.bank_or_building_society}"),
claimant_name: @claim.full_name
) %>
Expand Down
5 changes: 1 addition & 4 deletions config/locales/en.yml
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,7 @@ en:
title: "Check student loan plan"
payroll_details:
title: "Check bank/building society account details"
question: "%{claimant_name}'s %{bank_or_building_society} details have not been automatically validated. Has %{claimant_name} confirmed their %{bank_or_building_society} details?"
census_subjects_taught:
title: "Check eligible subjects are taught"
visa:
Expand Down Expand Up @@ -430,8 +431,6 @@ en:
title: "Does the claimant’s student loan amount and plan type match the information we hold about their loan?"
matching_details:
title: "Is this claim still valid despite having matching details with other claims?"
payroll_details:
title: "%{claimant_name}'s %{bank_or_building_society} details have not been automatically validated. Has %{claimant_name} confirmed their %{bank_or_building_society} details?"
additional_payments: &additional_payments
forms:
correct_school:
Expand Down Expand Up @@ -671,8 +670,6 @@ en:
title: Does the claimant's subject match the schools workforce census subjects
matching_details:
title: "Is this claim still valid despite having matching details with other claims?"
payroll_details:
title: "%{claimant_name}'s %{bank_or_building_society} details have not been automatically validated. Has %{claimant_name} confirmed their %{bank_or_building_society} details?"
reminders:
full_name: Full name
information_provided_further_details: For more details, you can read about payments and deductions for the %{link}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
click_on I18n.t("admin.tasks.payroll_details.title")

expect(page).to have_content I18n.t(
"student_loans.admin.task_questions.payroll_details.title",
"admin.tasks.payroll_details.question",
bank_or_building_society: I18n.t("admin.#{claim.bank_or_building_society}"),
claimant_name: claim.full_name
)
Expand Down

0 comments on commit 69bbf33

Please sign in to comment.