Expire requestable synchronously #2254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app deployed to https://apply-for-qts-review-2254-web.test.teacherservices.cloud/personas |
This adds a convenience method which returns true if the object should expire at some point (i.e. it's got an expires_at set).
This adds an expired and not_expired scope on the expirable objects which we can use to better filter the objects, and make it more readable.
This gives more time to each expiration requestable type to ensure they're finished before moving on to the next one.
When received the `expires_at` value becomes `nil` and `expires?` will return `false`. This is to ensure that we don't accidentally expire it when it shouldn't be.
This fixes an issue where if more than one requestable happened to expire at the same time, there is a race condition between when the status and action required at fields are updated, leading to incorrect application statuses.
thomasleese
force-pushed
the
perform-expiration-synchronously
branch
from
c290495 to
acf8145
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where if more than one requestable happened to expire at the same time, there is a race condition between when the status and action required at fields are updated, leading to incorrect application statuses.