Expire requestable synchronously

This fixes an issue where if more than one requestable happened to
expire at the same time, there is a race condition between when the
status and action required at fields are updated, leading to incorrect
application statuses.

app/jobs/expire_requestables_job.rb

@@ -7,8 +7,10 @@ def perform(requestable_class_name)
       .requested
       .not_received
       .not_expired
-      .find_each do |requestable|
-      ExpireRequestableJob.perform_later(requestable)
+      .each do |requestable|
+      if requestable.expires? && Time.zone.now > requestable.expires_at
+        ExpireRequestable.call(requestable:, user: "Expirer")
+      end
     end
   end
 end

spec/jobs/expire_requestables_spec.rb → spec/jobs/expire_requestables_job_spec.rb

@@ -7,28 +7,36 @@
     describe "#perform" do
       subject(:perform) { described_class.new.perform(class_name) }
 
-      let!(:requested_requestable) { create(:"requested_#{factory_name}") }
+      let!(:requested_requestable) do
+        create(:"requested_#{factory_name}", requested_at: 1.year.ago)
+      end
       let!(:received_requestable) { create(:"received_#{factory_name}") }
       let!(:expired_requestable) do
         create(:"requested_#{factory_name}", :expired)
       end
 
-      it "enqueues a job for each 'requested' #{class_name}s" do
-        expect { perform }.to have_enqueued_job(ExpireRequestableJob).with(
-          requested_requestable,
+      it "enqueues a job for each requested #{class_name}s" do
+        expect(ExpireRequestable).to receive(:call).with(
+          requestable: requested_requestable,
+          user: "Expirer",
         )
+        perform
       end
 
-      it "doesn't enqueue a job for 'received' #{class_name}s" do
-        expect { perform }.to_not have_enqueued_job(ExpireRequestableJob).with(
-          received_requestable,
+      it "doesn't enqueue a job for received #{class_name}s" do
+        expect(ExpireRequestable).to_not receive(:call).with(
+          requestable: received_requestable,
+          user: "Expirer",
         )
+        perform
       end
 
-      it "doesn't enqueue a job for 'expired' #{class_name}s" do
-        expect { perform }.to_not have_enqueued_job(ExpireRequestableJob).with(
-          expired_requestable,
+      it "doesn't enqueue a job for expired #{class_name}s" do
+        expect(ExpireRequestable).to_not receive(:call).with(
+          requestable: expired_requestable,
+          user: "Expirer",
         )
+        perform
       end
     end
   end