Always record assessment section timeline events #2226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
force-pushed
the
assessment-section-timeline-events
branch
3 times, most recently
from
96d0252 to
105fd7c
Compare
|
Review app deployed to https://apply-for-qts-review-2226-web.test.teacherservices.cloud/personas |
thomasleese
force-pushed
the
assessment-section-timeline-events
branch
from
105fd7c to
aa1887d
Compare
thomasleese
force-pushed
the
assessment-section-timeline-events
branch
from
aa1887d to
ee02846
Compare
This removes the need to return true or false from the service, since we're not using this value anywhere anyway.
When assessment sections are assessed we want to always record a timeline event to ensure this is captured even if the status changes, but the selected failure reasons might be different.
thomasleese
force-pushed
the
assessment-section-timeline-events
branch
from
ee02846 to
5956e06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When assessment sections are assessed we want to always record a timeline event to ensure this is captured even if the status changes, but the selected failure reasons might be different.
I've also refactored the service class to make it simpler.