Always record timeline events

When assessment sections are assessed we want to always record a
timeline event to ensure this is captured even if the status changes,
but the selected failure reasons might be different.

app/services/assess_assessment_section.rb

@@ -68,16 +68,13 @@ def update_application_form_assessor
   end
 
   def create_timeline_event(old_status:)
-    new_status = assessment_section.status
-    return if old_status == new_status
-
     CreateTimelineEvent.call(
       "assessment_section_recorded",
       application_form:,
       user:,
       assessment_section:,
       old_value: old_status,
-      new_value: new_status,
+      new_value: assessment_section.status,
     )
   end
 

spec/services/assess_assessment_section_spec.rb

@@ -134,14 +134,4 @@
       expect { call }.to_not change(assessment, :started_at)
     end
   end
-
-  context "when the state is the same" do
-    before { call }
-
-    it "doesn't record a timeline event" do
-      expect { call }.to_not have_recorded_timeline_event(
-        :assessment_section_recorded,
-      )
-    end
-  end
 end