Improve decline email and view content #1796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
force-pushed
the
decline-content
branch
from
98ea448 to
491a1c1
Compare
thomasleese
temporarily deployed
to
development
GitHub Actions
Inactive
|
Review app deployed to https://apply-for-qts-review-1796-web.test.teacherservices.cloud/personas |
thomasleese
force-pushed
the
decline-content
branch
from
491a1c1 to
1629ed4
Compare
thomasleese
temporarily deployed
to
development
GitHub Actions
Inactive
thomasleese
temporarily deployed
to
development
GitHub Actions
Inactive
thomasleese
force-pushed
the
decline-content
branch
from
6eb397c to
22dcc6c
Compare
thomasleese
temporarily deployed
to
development
GitHub Actions
Inactive
thomasleese
force-pushed
the
decline-content
branch
from
22dcc6c to
4048179
Compare
thomasleese
temporarily deployed
to
development
GitHub Actions
Inactive
thomasleese
force-pushed
the
decline-content
branch
from
4048179 to
593795f
Compare
thomasleese
temporarily deployed
to
development
GitHub Actions
Inactive
thomasleese
force-pushed
the
decline-content
branch
from
593795f to
7efcf74
Compare
thomasleese
temporarily deployed
to
development
GitHub Actions
Inactive
thomasleese
force-pushed
the
decline-content
branch
from
7efcf74 to
6fa6dbd
Compare
thomasleese
temporarily deployed
to
development
GitHub Actions
Inactive
thomasleese
force-pushed
the
decline-content
branch
from
6fa6dbd to
890dbfa
Compare
thomasleese
temporarily deployed
to
development
GitHub Actions
Inactive
thomasleese
force-pushed
the
decline-content
branch
from
890dbfa to
5dda5b4
Compare
thomasleese
temporarily deployed
to
development
GitHub Actions
Inactive
This changes the content we show for the reference number in various views as requested by our content designers.
I've renamed it and combined the decline reason methods together so we can use them in the views and in the mailers.
thomasleese
force-pushed
the
decline-content
branch
from
5dda5b4 to
f8c61ad
Compare
thomasleese
temporarily deployed
to
development
GitHub Actions
Inactive
thomasleese
force-pushed
the
decline-content
branch
from
f8c61ad to
794f0da
Compare
thomasleese
temporarily deployed
to
development
GitHub Actions
Inactive
thomasleese
force-pushed
the
decline-content
branch
from
794f0da to
93007e2
Compare
thomasleese
temporarily deployed
to
development
GitHub Actions
Inactive
thomasleese
force-pushed
the
decline-content
branch
from
93007e2 to
1bd794a
Compare
thomasleese
temporarily deployed
to
development
GitHub Actions
Inactive
This updates the content of the decline email and view to match the changes requested by our content designers.
thomasleese
force-pushed
the
decline-content
branch
from
1bd794a to
1beea5f
Compare
thomasleese
temporarily deployed
to
development
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the content on the decline email and view as requested by our content designers. I've also refactored the view object to make it easy to use in the mailer and the view.
Trello Card
Screenshots