Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2322-send-referee-reminders-to-applicants #1778

Merged
merged 7 commits into from
Nov 16, 2023

Conversation

richardpattinson
Copy link
Contributor

@richardpattinson richardpattinson commented Oct 31, 2023

When reference request reminder emails are sent to referees the associated teacher will be notified. They will be contacted when their referees have 28 and 14 days to respond.

@richardpattinson richardpattinson requested a review from a team as a code owner October 31, 2023 11:14
@richardpattinson richardpattinson force-pushed the 2322-send-referee-reminders-to-applicants branch 4 times, most recently from 0fc160e to fc7a359 Compare November 9, 2023 14:30
app/models/teacher.rb Outdated Show resolved Hide resolved
app/views/teacher_mailer/references_reminder.text.erb Outdated Show resolved Hide resolved
app/views/teacher_mailer/references_reminder.text.erb Outdated Show resolved Hide resolved
spec/mailers/teacher_mailer_spec.rb Show resolved Hide resolved
app/models/concerns/expirable.rb Outdated Show resolved Hide resolved
app/models/teacher.rb Outdated Show resolved Hide resolved
@richardpattinson richardpattinson force-pushed the 2322-send-referee-reminders-to-applicants branch 3 times, most recently from fa6b276 to 4f2184d Compare November 10, 2023 09:40
app/models/concerns/expirable.rb Outdated Show resolved Hide resolved
app/models/teacher.rb Outdated Show resolved Hide resolved
app/views/teacher_mailer/references_reminder.text.erb Outdated Show resolved Hide resolved
spec/mailers/teacher_mailer_spec.rb Outdated Show resolved Hide resolved
app/models/teacher.rb Outdated Show resolved Hide resolved
Copy link

This removes the link between the two making it possible for objects
which don’t expire (like teachers or application forms) to also have
reminder emails.
This adds a new column to reminder emails for capturing the name of the
reminder email, allowing us to send multiple different types of reminder
emails from a single remindable.
This adds the ability to send multiple different kinds of reminder
emails from a single remindable by introducing a new method to the
remindable concern and passing the name in to the methods.
@thomasleese thomasleese force-pushed the 2322-send-referee-reminders-to-applicants branch from 6524952 to 1101576 Compare November 15, 2023 17:29
@thomasleese thomasleese force-pushed the 2322-send-referee-reminders-to-applicants branch from bb7efce to 7ff3ac9 Compare November 16, 2023 09:46
@thomasleese thomasleese force-pushed the 2322-send-referee-reminders-to-applicants branch from 7ff3ac9 to bf3c9bf Compare November 16, 2023 09:50
@thomasleese thomasleese force-pushed the 2322-send-referee-reminders-to-applicants branch from bf3c9bf to ba01126 Compare November 16, 2023 09:50
@thomasleese thomasleese force-pushed the 2322-send-referee-reminders-to-applicants branch from ba01126 to fa24044 Compare November 16, 2023 10:36
This adds the reminder email sent to teachers when their references
haven't been returned promptly.
This updates the application form to send reminder emails for
references.
This updates the content for reference emails that we send to applicants
and referees.
This ensures that any email addresses in mailer views are rendered as
clickable links.
@thomasleese thomasleese merged commit 3684ccd into main Nov 16, 2023
12 checks passed
@thomasleese thomasleese deleted the 2322-send-referee-reminders-to-applicants branch November 16, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants