Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content changes made to preview page for further_information_requests #1764

Merged
merged 4 commits into from
Oct 18, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ def item_name(item)
"teacher_interface.further_information_request.show.failure_reason.#{item.failure_reason_key}",
)
when "work_history_contact"
"Add your work history contact’s details"
"Add work history details"
when "document"
"Upload your #{I18n.t("document.document_type.#{item.document.document_type}")} document"
end
Expand Down
Original file line number Diff line number Diff line change
@@ -1,29 +1,43 @@
<% content_for :page_title, "Check the further information you’re asking the applicant for" %>
<% content_for :back_link_url, edit_assessor_interface_application_form_assessment_path(@application_form, @assessment) %>

<h1 class="govuk-heading-xl">
Check the further information you’re asking the applicant for
</h1>
<h1 class="govuk-heading-xl">Check the information you’re asking the applicant for</h1>

<p class="govuk-body">This screen shows your reasons for requesting further information, along with your notes to the applicant.</p>
<p class="govuk-body">If you need to change your notes, you’ll need to go back to the relevant section.</p>
<% @further_information_request.items.group_by(&:failure_reason_key).each do |failure_reason_key, items| %>
<% if failure_reason_key == "school_details_cannot_be_verified" %>
<section class="app-further-information-request-item">
<h2 class="govuk-heading-m">Reason for request</h2>
<% if items.size == 1 %>
<p class="govuk-body">We were unable to verify the details for <%= items.first.work_history.school_name %>.</p>
<% else %>
<p class="govuk-body">We were unable to verify the details for:</p>
<ul class="govuk-list govuk-list--bullet">
<% items.each do |item| %>
<li><%= item.work_history.school_name %></li>
<% end %>
</ul>
<% end %>
<h2 class="govuk-heading-m">Note to applicant</h2>

<h2 class="govuk-heading-l">Your further information request reasons and notes</h2>
<%= govuk_inset_text do %>
<%= simple_format items.first.failure_reason_assessor_feedback %>
<% end %>
</section>
<% else %>
<% items.each do |item| %>
<section class="app-further-information-request-item">
<p class="govuk-body"><%= t(item.failure_reason_key, scope: %i[assessor_interface assessment_sections failure_reasons as_statement]) %></p>

<% @further_information_request.items.each do |item| %>
<section class="app-further-information-request-item">
<h3 class="govuk-heading-s"><%= t(item.failure_reason_key, scope: %i[assessor_interface assessment_sections failure_reasons as_statement]) %></h3>
<p class="govuk-body govuk-!-margin-bottom-2">Your note to the applicant:</p>
<h2 class="govuk-heading-m">Note to applicant</h2>

<%= govuk_inset_text do %>
<%= simple_format item.failure_reason_assessor_feedback %>
<%= govuk_inset_text do %>
<%= simple_format item.failure_reason_assessor_feedback %>
<% end %>
</section>
<% end %>
</section>
<% end %>
<% end %>

<h2 class="govuk-heading-l">Send the further information request email</h2>
<p class="govuk-body">On the next screen, you’ll see a preview of the email.</p>

<div class="govuk-button-group">
<%= govuk_button_link_to "Continue", new_assessor_interface_application_form_assessment_further_information_request_path(@application_form, @assessment) %>
<%= govuk_button_link_to "Back to overview", assessor_interface_application_form_path(@application_form), secondary: true %>
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,5 @@
<h2 class="govuk-heading-m">We need some more information</h2>

<p class="govuk-body">The assessor needs you to provide some additional information so they can continue reviewing your application.</p>

<div class="govuk-inset-text">
You may need to upload 1 or more documents. Make sure any files you upload clearly show the whole document or page, and that any text is easy to read.
</div>

<p class="govuk-body">You must add all of the requested information, so the assessor can continue reviewing your QTS application.</p>
<p class="govuk-body">The assessor needs you to provide more information so they can continue reviewing your application.</p>

<%= govuk_start_button(text: "Start now", href: teacher_interface_application_form_further_information_request_path(view_object.further_information_request)) %>
2 changes: 1 addition & 1 deletion config/locales/assessor_interface.en.yml
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ en:
registration_number: We could not find the applicant’s reference number, or the number was in the wrong format. The applicant will need to supply the number again.
registration_number_alternative: We could not find the applicant’s reference number. The applicant will need to upload written proof of recognition as a teacher instead.
satisfactory_evidence_work_history: The information provided on work history is not sufficient to award QTS.
school_details_cannot_be_verified: We could not verify the details of one of the schools that the applicant has entered.
school_details_cannot_be_verified: We could not verify school details entered by the applicant.
teaching_certificate_illegible: The teaching qualification certificate (or translation) is illegible or in a format that we cannot accept.
teaching_hours_not_fulfilled: The required teaching hours have not been fulfilled.
teaching_qualification: We were not provided with sufficient evidence to confirm the teaching qualification entered on the online application form.
Expand Down
4 changes: 2 additions & 2 deletions config/locales/helpers.en.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ en:
assessor_interface_assessment_section_form:
selected_failure_reasons: Select all options that are relevant to you.
failure_reason_notes:
text: This FI reason gives the applicant a free text box. Use this space to give them clear instructions on what they need to provide.
text: This FI allows the applicant to send us a typed response. Use this space to give them clear instructions on what they need to provide.
document: This FI reason asks the applicant to upload a file. Use this space to give them clear instructions on what they need to provide.
decline: As this reason triggers a decline, you do not need to add a note, but you can use the space below to add anything you feel might be helpful, if you want to.
assessor_interface_create_note_form:
Expand Down Expand Up @@ -278,7 +278,7 @@ en:
assessor_interface_assessment_section_form:
selected_failure_reasons: What are the reasons for your recommendation?
scotland_full_registration: Does the applicant have or are they eligible for full registration?
school_details_cannot_be_verified_work_history_checked: Choose the schools that need reference details to be amended
school_details_cannot_be_verified_work_history_checked: Select the school that we were unable to verify (there may be more than one)
assessor_interface_filter_form:
action_required_by: Action required by
assessor_ids: Assessor name
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -75,9 +75,7 @@ def when_i_select_request_further_information

def and_i_see_the_further_information_request_items
expect(assessor_request_further_information_page.items.count).to eq(1)
expect(
assessor_request_further_information_page.items.first.heading.text,
).to eq(
expect(assessor_request_further_information_page).to have_content(
"Subjects entered are acceptable for QTS, but the uploaded qualifications do not match them.",
)
expect(
Expand Down
6 changes: 2 additions & 4 deletions spec/system/teacher_interface/further_information_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -159,9 +159,7 @@ def and_i_see_the_check_your_answers_items
expect(rows.first.key.text).to eq(
"Tell us more about the subjects you can teach",
)
expect(rows.second.key.text).to eq(
"Add your work history contact’s details",
)
expect(rows.second.key.text).to eq("Add work history details")

expect(rows.last.key.text).to eq("Upload your identity document")
end
Expand Down Expand Up @@ -233,7 +231,7 @@ def text_check_answers_item

def work_history_task_list_item
teacher_further_information_requested_page.task_list.find_item(
"Add your work history contact’s details",
"Add work history details",
)
end

Expand Down
Loading