Content changes made to preview page for further_information_requests #1764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasleese
reviewed
Oct 13, 2023
| <li><%= item.work_history.school_name %></li> | ||
| <% end %> | ||
| </ul> | ||
| <%end%> |
There was a problem hiding this comment.
Suggested change
| <%end%> | |
| <% end %> |
| <h2 class="govuk-heading-s">Reason for request</h2> | ||
| <% if items.size == 1 %> | ||
| <p class="govuk-body">We were unable to verify the details for <%= items.first.work_history.school_name %></p> | ||
| <% elsif items.size > 1 %> |
There was a problem hiding this comment.
Suggested change
| <% elsif items.size > 1 %> | |
| <% else %> |
Probably fine to make this an else.
| <section class="app-further-information-request-item"> | ||
| <h2 class="govuk-heading-s">Reason for request</h2> | ||
| <% if items.size == 1 %> | ||
| <p class="govuk-body">We were unable to verify the details for <%= items.first.work_history.school_name %></p> |
There was a problem hiding this comment.
Suggested change
| <p class="govuk-body">We were unable to verify the details for <%= items.first.work_history.school_name %></p> | |
| <p class="govuk-body">We were unable to verify the details for <%= items.first.work_history.school_name %>.</p> |
thomasleese
approved these changes
Oct 16, 2023
|
Review app deployed to https://apply-for-qts-review-1764-web.test.teacherservices.cloud/personas |
syed87
force-pushed
the
2305-content-changes-for-fi-for-referee-details
branch
from
6624948 to
7eb9fe8
Compare
syed87
force-pushed
the
2305-content-changes-for-fi-for-referee-details
branch
from
7eb9fe8 to
7b6d7c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Content changes made based on design document https://educationgovuk-my.sharepoint.com/:p:/g/personal/dominic_collins_education_gov_uk/EWwb_4aR-0lPkmLIfGYvbXkBj4_bRiQtX9TFtD3pNMwGSQ?e=hHJU3M&PreviousSessionID=b69adf7d-f7c4-4538-4af2-d76bcaa9e289
https://trello.com/c/XUBcaLA5/2329-check-developer-access