Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make requestables verifiable #1733

Merged
merged 4 commits into from
Oct 5, 2023
Merged

Make requestables verifiable #1733

merged 4 commits into from
Oct 5, 2023

Conversation

thomasleese
Copy link
Contributor

@thomasleese thomasleese commented Oct 4, 2023

This updates the requestables to allow them to be verified by an admin user by adding the necessary database fields and service class.

Depends on #1732

Trello Card

@thomasleese thomasleese force-pushed the reviewable-requestables branch from 010ee43 to b41de1c Compare October 4, 2023 18:30
@thomasleese thomasleese changed the title Add verify fields to requestables Make requestable verifiable Oct 4, 2023
@thomasleese thomasleese changed the title Make requestable verifiable Make requestables verifiable Oct 5, 2023
@thomasleese thomasleese marked this pull request as ready for review October 5, 2023 09:39
@thomasleese thomasleese force-pushed the reviewable-requestables branch from b41de1c to 58afbb1 Compare October 5, 2023 09:39
@thomasleese thomasleese requested a review from a team as a code owner October 5, 2023 09:39
This adds new fields to requestables for capturing when an admin has
verified the requests directly, and if passed, avoids the need for an
assessor to review.
This updates the code to use the new review and verify fields which have
been added to the requestable models.
This adds a service class which we can use to mark a requestable as
verified.
This adds a form which will handle when the user wishes to verify a
requestable.
@thomasleese thomasleese force-pushed the reviewable-requestables branch from 72f2009 to c7ef0f3 Compare October 5, 2023 13:44
Copy link
Contributor

@richardpattinson richardpattinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great; no comments

@thomasleese thomasleese merged commit eacc04f into main Oct 5, 2023
12 checks passed
@thomasleese thomasleese deleted the reviewable-requestables branch October 5, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants