Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add review assessment recommendation #1734

Merged
merged 2 commits into from
Oct 6, 2023

Conversation

thomasleese
Copy link
Contributor

This adds a review recommendation to the assessment and adds reviews items to the task list.

Depends on #1733

Trello Card

@thomasleese thomasleese force-pushed the assessment-review-recommendation branch 2 times, most recently from dcc4df6 to f36a235 Compare October 5, 2023 13:47
@thomasleese thomasleese marked this pull request as ready for review October 5, 2023 14:52
@thomasleese thomasleese requested a review from a team as a code owner October 5, 2023 14:52
@thomasleese thomasleese force-pushed the assessment-review-recommendation branch 2 times, most recently from f36a235 to 28b8927 Compare October 5, 2023 15:07
@thomasleese thomasleese enabled auto-merge October 5, 2023 15:15
@thomasleese thomasleese force-pushed the assessment-review-recommendation branch from ca2f2d8 to 0523741 Compare October 5, 2023 15:17
@thomasleese thomasleese disabled auto-merge October 5, 2023 18:13
@thomasleese thomasleese force-pushed the assessment-review-recommendation branch from 0523741 to a10a799 Compare October 5, 2023 18:50
@thomasleese thomasleese enabled auto-merge October 6, 2023 08:49
This adds a new assessment recommendation called review which is used
when we need to send an application to review after verification.
This adds a new task list item for assessors for accessing any
verifications that need reviewing.
@thomasleese thomasleese force-pushed the assessment-review-recommendation branch from a10a799 to 86f3ff8 Compare October 6, 2023 09:31
Copy link
Contributor

@syed87 syed87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@thomasleese thomasleese merged commit 3a041bd into main Oct 6, 2023
12 checks passed
@thomasleese thomasleese deleted the assessment-review-recommendation branch October 6, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants