Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add application form stage #1689

Merged
merged 5 commits into from
Sep 27, 2023
Merged

Add application form stage #1689

merged 5 commits into from
Sep 27, 2023

Conversation

thomasleese
Copy link
Contributor

@thomasleese thomasleese commented Sep 14, 2023

This adds the new stage field to application forms which we'll be using in the future to allow users to filter on.

Depends on #1671.

Trello Card

@thomasleese thomasleese force-pushed the application-form-stage branch from 82ecf0c to 7fa03d7 Compare September 14, 2023 09:53
@thomasleese thomasleese force-pushed the application-form-stage branch 4 times, most recently from 093c755 to 896a2ba Compare September 19, 2023 10:40
@thomasleese thomasleese force-pushed the application-form-stage branch from 896a2ba to eedb577 Compare September 24, 2023 12:15
This will be used to capture at what stage of the workflow an
application form is in.
This adds some traits to the application form factory to make it easier
to write tests using the stage field.
This adds a new type of timeline event which captures whenever the
stage of an application has changed.
This updates the timeline entry component to be able to show the new
stage changed timeline events, explaining to the user what has changed.
This adds the ability for the status updater class to also update the
stage value, ensuring that it's kept up to date with the status.
@thomasleese thomasleese force-pushed the application-form-stage branch from eedb577 to fbaa384 Compare September 27, 2023 11:33
@thomasleese thomasleese marked this pull request as ready for review September 27, 2023 11:34
@thomasleese thomasleese requested a review from a team as a code owner September 27, 2023 11:34
Copy link
Contributor

@syed87 syed87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@thomasleese thomasleese merged commit 1676c9b into main Sep 27, 2023
12 checks passed
@thomasleese thomasleese deleted the application-form-stage branch September 27, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants