Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add application form statuses #1697

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Add application form statuses #1697

merged 3 commits into from
Sep 28, 2023

Conversation

thomasleese
Copy link
Contributor

@thomasleese thomasleese commented Sep 14, 2023

This adds the new statuses field to application forms which we'll be using in the future to allow users to filter on.

Depends on #1689

Trello Card

@thomasleese thomasleese force-pushed the application-form-statuses branch 4 times, most recently from 4f4a3fe to 7ade1c7 Compare September 19, 2023 10:40
@thomasleese thomasleese force-pushed the application-form-statuses branch 3 times, most recently from 8f7f193 to 29fb8ed Compare September 27, 2023 16:16
@thomasleese thomasleese marked this pull request as ready for review September 27, 2023 16:16
@thomasleese thomasleese requested a review from a team as a code owner September 27, 2023 16:16
This adds a new column on application forms for tracking the various
statuses an application form is currently in. This will eventually
replace the `status` and `waiting_on`, `received` and `overdue` columns.
This updates the existing traits for the factories to encorporate the
new statuses column.
@thomasleese thomasleese force-pushed the application-form-statuses branch from 29fb8ed to 69785ba Compare September 27, 2023 17:42
This adds the ability for the status updater class to also update the
statuses value, ensuring that it's kept up to date with the status.
@thomasleese thomasleese force-pushed the application-form-statuses branch from 69785ba to cc6757c Compare September 28, 2023 09:13
Copy link
Contributor

@syed87 syed87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@thomasleese thomasleese merged commit 238e3b3 into main Sep 28, 2023
12 checks passed
@thomasleese thomasleese deleted the application-form-statuses branch September 28, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants