Remove code related to OTP

This removes any code related to the one time password feature for teachers which is no longer being used anywhere.
DFE-Digital · Aug 9, 2023 · fb29dc9 · fb29dc9
1 parent 232c744
commit fb29dc9
Show file tree

Hide file tree

Showing 22 changed files with 0 additions and 487 deletions.
diff --git a/adr/00010-using-email-based-otp-for-user-sign-in.md b/adr/00010-using-email-based-otp-for-user-sign-in.md
diff --git a/app/controllers/teachers/otp_controller.rb b/app/controllers/teachers/otp_controller.rb
diff --git a/app/forms/teachers/otp_form.rb b/app/forms/teachers/otp_form.rb
diff --git a/app/lib/devise/models/otp_authenticatable.rb b/app/lib/devise/models/otp_authenticatable.rb
diff --git a/app/lib/devise/otp.rb b/app/lib/devise/otp.rb
diff --git a/app/lib/devise/strategies/otp_authenticatable.rb b/app/lib/devise/strategies/otp_authenticatable.rb
diff --git a/app/mailers/devise_mailer.rb b/app/mailers/devise_mailer.rb
@@ -13,9 +13,4 @@ def devise_mail(record, action, opts = {}, &_block)
     initialize_from_record(record)
     view_mail(GOVUK_NOTIFY_TEMPLATE_ID, headers_for(action, opts))
   end
-
-  def otp(record, otp, opts = {})
-    @otp = otp
-    devise_mail(record, :otp, opts)
-  end
 end
diff --git a/app/models/teacher.rb b/app/models/teacher.rb
@@ -37,11 +37,6 @@ def application_form
       application_forms.not_withdrawn.order(created_at: :desc).first
   end
 
-  def send_otp(*)
-    otp = Devise::Otp.derive_otp(secret_key)
-    send_devise_notification(:otp, otp)
-  end
-
   def send_magic_link(*)
     token = Devise::Passwordless::LoginToken.encode(self)
     send_devise_notification(:magic_link, token, {})

diff --git a/app/views/teachers/mailer/otp.text.erb b/app/views/teachers/mailer/otp.text.erb
diff --git a/app/views/teachers/otp/new.html.erb b/app/views/teachers/otp/new.html.erb
diff --git a/app/views/teachers/otp/retry.html.erb b/app/views/teachers/otp/retry.html.erb
diff --git a/config/initializers/devise.rb b/config/initializers/devise.rb
@@ -320,13 +320,6 @@
   # ==> Warden configuration
   # If you want to use other strategies, that are not supported by Devise, or
   # change the failure app, you can configure them inside the config.warden block.
-  config.warden do |manager|
-    manager.strategies.add(
-      :otp_authenticatable,
-      Devise::Strategies::OtpAuthenticatable,
-    )
-    manager.default_strategies(scope: :teacher).unshift(:otp_authenticatable)
-  end
 
   #
   # ==> Mountable engine configurations

diff --git a/config/initializers/filter_parameter_logging.rb b/config/initializers/filter_parameter_logging.rb
@@ -12,7 +12,6 @@
   crypt
   salt
   certificate
-  otp
   ssn
   email
   given_names

diff --git a/config/locales/devise.en.yml b/config/locales/devise.en.yml
@@ -18,8 +18,6 @@ en:
       unauthenticated: "You need to sign in or sign up before continuing."
       unconfirmed: "You have to confirm your email address before continuing."
       magic_link_invalid: "Invalid or expired login link."
-      teacher:
-        otp_invalid: "Invalid code"
     mailer:
       confirmation_instructions:
         subject: "Your QTS application link"
@@ -33,8 +31,6 @@ en:
         subject: "Password Changed"
       magic_link:
         subject: "Confirm your email address"
-      otp:
-        subject: "Confirm your email address"
     omniauth_callbacks:
       failure: 'Could not authenticate you from %{kind} because "%{reason}".'
       success: "Successfully authenticated from %{kind} account."

diff --git a/config/locales/teacher_interface.en.yml b/config/locales/teacher_interface.en.yml
@@ -1,10 +1,4 @@
 en:
-  teachers:
-    otp:
-      retry:
-        expired: Your security code has expired. Try again.
-        exhausted: You've had too many incorrect sign in attempts. Try again.
-
   teacher_interface:
     application_forms:
       show:
@@ -159,11 +153,6 @@ en:
   activemodel:
     errors:
       models:
-        teachers/otp_form:
-          attributes:
-            otp:
-              blank: Enter your confirmation code
-              wrong_length: Enter a valid code
         teacher_interface/age_range_form:
           attributes:
             minimum:
-Original file line number
+Diff line change
@@ Expand Up / @@ -12,7 +12,6 @@ @@
       crypt
       salt
       certificate
-      otp
       ssn
       email
       given_names
@@ Expand Down @@