Remove OTP columns

This removes the columns related to one time passwords (OTP) from the teachers table, as we've stopped using it as a method of authentication.
DFE-Digital · Aug 9, 2023 · 232c744 · 232c744
1 parent c46bcee
commit 232c744
Show file tree

Hide file tree

Showing 7 changed files with 9 additions and 16 deletions.
diff --git a/app/models/teacher.rb b/app/models/teacher.rb
@@ -9,9 +9,6 @@
 #  email              :string           default(""), not null
 #  last_sign_in_at    :datetime
 #  last_sign_in_ip    :string
-#  otp_created_at     :datetime
-#  otp_guesses        :integer          default(0), not null
-#  secret_key         :string
 #  sign_in_count      :integer          default(0), not null
 #  trn                :string
 #  uuid               :uuid             not null

diff --git a/config/analytics.yml b/config/analytics.yml
@@ -353,8 +353,6 @@
     - id
     - last_sign_in_at
     - last_sign_in_ip
-    - otp_created_at
-    - otp_guesses
     - sign_in_count
     - trn
     - updated_at

diff --git a/config/analytics_blocklist.yml b/config/analytics_blocklist.yml
@@ -12,5 +12,3 @@
     - confirmation_token
     - unlock_token
     - invitation_token
-  :teachers:
-    - secret_key
diff --git a/db/migrate/20230808065424_remove_otp_from_teachers.rb b/db/migrate/20230808065424_remove_otp_from_teachers.rb
@@ -0,0 +1,9 @@
+class RemoveOtpFromTeachers < ActiveRecord::Migration[7.0]
+  def change
+    change_table :teachers, bulk: true do |t|
+      t.remove :secret_key, type: :string
+      t.remove :otp_guesses, type: :integer, default: 0, null: false
+      t.remove :otp_created_at, type: :datetime
+    end
+  end
+end
diff --git a/db/schema.rb b/db/schema.rb
diff --git a/spec/factories/teachers.rb b/spec/factories/teachers.rb
@@ -9,9 +9,6 @@
 #  email              :string           default(""), not null
 #  last_sign_in_at    :datetime
 #  last_sign_in_ip    :string
-#  otp_created_at     :datetime
-#  otp_guesses        :integer          default(0), not null
-#  secret_key         :string
 #  sign_in_count      :integer          default(0), not null
 #  trn                :string
 #  uuid               :uuid             not null

diff --git a/spec/models/teacher_spec.rb b/spec/models/teacher_spec.rb
@@ -9,9 +9,6 @@
 #  email              :string           default(""), not null
 #  last_sign_in_at    :datetime
 #  last_sign_in_ip    :string
-#  otp_created_at     :datetime
-#  otp_guesses        :integer          default(0), not null
-#  secret_key         :string
 #  sign_in_count      :integer          default(0), not null
 #  trn                :string
 #  uuid               :uuid             not null