Refactor/core framework #221

ujjwal-cyph · 2023-04-26T09:38:38Z

Things covered previously

Add unit test framework feat(build): Integrate unit test framework #197
Integrate code coverage tool Add code coverage for simulator build #207
Integrate unit tests in CI on simulator test (ci): Run unit tests in CI #227

Things to be covered:

Implement events APIs
- UI Events (normal event) UI refactor with event getter #211 feat(ui): Added event getters and setters for ui module #204
- USB Events (normal event) feat (core): Add api for usb events interfacing #206
- NFC Events (normal event) Integrate NFC events to OS event getter #218 Feat/nfc integrate os get evt #215 Feat/nfc event/chi 4736 #214
- P0 Events (high priority events) feat (core): Implement p0 event getters #202
- Implement OS Event getter feat(core): Main event getter module #210
Necessary UI refactor
- Follow up fix for Increase the defined max word length to 16 to match wallet names #22
- Consistency of UI destructors refactor(ui): Call ui destructor from lv_event_delete case #217
Integrate protobuf
- Integrate nanopb into build system feat (build): Integrate protobuf using nanopb #222
- Integrate core protobuf struct refactor: Use protobuf struct for status payload #232
- Add nanopb compile options feat (build): Add bash script to auto-generate options file #237
- Add app id check in data requests Check core msg for valid app id #238
Enable webusb, HID Feat/webusb #226 Fix/webusb collision #234
Implement main menu
- Implement UI engine feat(core): Implement flow engine for event handling and ux navigation #223
- Implement menu navigation and event handling refactor: Use engine to render level one main menu #229
Implement app functionality & protobuf struct
- Onboarding
  - Flash storage feat: Implement onboarding flow management on ram #270
  - Joystick events feat (ui): Add joystick training to onboarding #256
  - Port card auth
  - Device auth refactor: Use protobuf struct to perform device authentication #236
  - Engine and Handlers feat: Basic skeleton for the manager app #248
- Manager - Get device info feat: Add function to populate device info fields #250
- Manager - Engine and Event Handlers feat: Implement onboarding ui screens and add flow on startup #246 feat(app): Added apis for decode query and encode result #247 feat: Basic skeleton for the manager app #248 fix(app): Updated parameter type for decode api #249
- Manager - Export/Add/Get wallet feat: Export wallet list to host #290
- Manager - Device auth refactor: Use protobuf struct to perform device authentication #236
- Flow status synchronization for coin operations feat: Enable flow-status sync during seed reconstruction steps #349
- BTC Family feat: Add "BTC" app skeleton #283
  - BTC - Add account feat (app): Enable support for exporting xpubs to host #291 refactor (app): Setup bitcoin family interface & integrate Bitcoin #315
  - BTC - View receive address feat (app): Integrate get_public_key in btc #296 refactor (app): Setup bitcoin family interface & integrate Bitcoin #315
  - BTC - Send funds refactor (app): Bitcoin transaction porting #331 refactor (app): Extend query handling of transaction signing #332 refactor: Bitcoin txn validation & signing #348
  - Dash - Add account - refactor (app): Support for Dash coin #316
  - Dash - View receive address - refactor (app): Support for Dash coin #316
  - Dash - Send funds - refactor (app): Support for Dash coin #316
  - Dogecoin - Add account - feat: add btc app configs for ltc and doge #354
  - Dogecoin - View receive address - feat: add btc app configs for ltc and doge #354
  - Dogecoin - Send funds - feat: add btc app configs for ltc and doge #354
  - Litecoin - Add account - feat: add btc app configs for ltc and doge #354
  - Litecoin - View receive address - feat: add btc app configs for ltc and doge #354
  - Litecoin - Send funds - feat: add btc app configs for ltc and doge #354
- EVM Family - refactor: Add support for evm chain configuration #373
  - Ethereum - Add account - Refactor/core framework evm #370
  - Ethereum - View receive address - feat: Handle request for user verified public key for evm #383
  - Ethereum - Send funds - refactor (app): Add evm basic transaction support #390
  - Ethereum - Sign message - Refactor/evm sign msg/prf 5020 #396
  - EVM - Add account
  - EVM - View receive address
  - EVM - Send funds
- NEAR - Add account/ Receive on Implicit account - feat: Implement get public key function for 'NEAR' #372
- NEAR - Sign txn and add explicit account flow - feat: Implement 'NEAR' sign txn for transfer and add account fn call #379
- NEAR - Receive on Explicit account
- SOLANA - Add account
- SOLANA - View receive address
- SOLANA - Send funds

- fix transaction flow logic - export function and type for unit-test

…fig (#387)

) Implements https://app.clickup.com/t/9002019994/PRF-5022

chore: Remove dead code

…-creation/PRF-6203

…-6557 feat(core): Verify fetched wallets

…6558 Verify wallet before delete

…efore-delete fix(core): Treat unverified wallets as non existant

chore: Update cmake required version

…dated fix(core): Update factory reset condition to ignore write attempt

…-creation/PRF-6203

…tion/PRF-6203 feat(core): Handle wallet collision while creation

amanCypherock · 2023-12-27T13:52:06Z

LGTM

ujjwal-cyph self-assigned this Apr 26, 2023

amanCypherock mentioned this pull request Apr 26, 2023

Increase the defined max word length to 16 to match wallet names #22

Merged

Ujjwal0501 and others added 28 commits August 25, 2023 17:55

chore: Move transaction_size to proto struct

47e08ea

refactor (app): Improvement and fixes

801529f

- fix transaction flow logic - export function and type for unit-test

test (app): Add evm txn test

f5bc411

chore: Add support for stitching transaction

cf3e308

chore: Cleanup old wallet menu and add coin flow

daf4f70

chore: Remove level one initial to fix build issues

a88de78

chore: Cleanup old wallet menu and add coin flow (#395)

6d5448c

fix: Correct file name in comment

b2b5488

chore: Rename struct name prefix to evm_

63de7da

chore: Add missing doxygen comment

5aec4fb

refactor (app): Add evm basic transaction support (#390)

aa6a6ec

refactor(app): Added sign msg untested changes

5075f4b

fix: Updates based on review comments

e05628f

chore(app): Added comments for helper functions

1b6b77a

fix: Update user facing message to clear device data

b977c3f

chore(app): Minor changes

c198030

feat: Implement clear user data to delete wallets, pairing & user con…

2be9404

…fig (#387)

refactor(app): Added msg size to init req

381706a

fix(app): Duplicate function prototype removed

c912a70

fix: Refresh timeout counter in case joystick movement is detected (#393

22c8fd7

) Implements https://app.clickup.com/t/9002019994/PRF-5022

fix: Allow exporting logs in case of restricted app mode

e1486ba

feat: Implement 'NEAR' sign txn for transfer and add account fn call

13c5f3b

fix: Use confirmation screen for value for better readability

5c42719

chore: Add test case for transfer action to custom account

4e7f137

fix: Update call to flow status api in 'NEAR' sign txn flow

f90b1c7

fix: Update user confirmations to unify sign txn flow for diff actions

8185286

fix: Update invocation to core apis as interfaces are changed

2f828a8

fix: Remove reference for btc in near file

6c56c72

ujjwal-cyph and others added 26 commits December 16, 2023 12:53

Merge branch 'refactor/core-framework' into source-clean-up

5a66284

Merge pull request #412 from Cypherock/source-clean-up

4a9dbbb

chore: Remove dead code

refactor(core): Refactored wallet nonce derivation and size macro rename

062ae98

fix(core): Updated acc to review suggestions

6c82ad8

feat(core): Verify fetched wallets

73979c7

fix(ui): Verification failure message updated

da01995

fix(core): Added log and error code for verification failures

ddbb03d

fix(nfc): Updated acc to review suggestions

0efecdc

feat(core): Record card write attempt

2db29ea

fix(core): Verify before delete changes

06c299a

fix(core): Updated factory reset wallet checks condition

053a609

refactor(core): Refactored acc to review suggestions

fd11071

Merge branch 'refactor/core-framework' into feat/save-wallet-nonce-on…

ee796b6

…-creation/PRF-6203

fix(core): Updated acc to review suggestions

ea971c0

Merge pull request #445 from Cypherock/feat/verify-fetched-wallet/PRF…

1747f42

…-6557 feat(core): Verify fetched wallets

Merge pull request #446 from Cypherock/feat/verify-before-delete/PRF-…

1d6e70c

…6558 Verify wallet before delete

fix(core): Treat unverified wallets as non existant

0b3ed3e

fix(core): Changes acc to review suggestions

4e391d9

Merge pull request #450 from Cypherock/fix/handle-unverified-wallet-b…

7d8bd84

…efore-delete fix(core): Treat unverified wallets as non existant

chore: Update cmake required version

4c01c1c

fix(core): Update factory reset condition to ignore write attempt

68bae40

fix(core): Hard fault after wrong pin entry

2855967

Merge pull request #452 from Cypherock/update-cmake-version

f88f382

chore: Update cmake required version

Merge pull request #451 from Cypherock/fix/factory-reset-condiiton-up…

be0afc5

…dated fix(core): Update factory reset condition to ignore write attempt

Merge branch 'refactor/core-framework' into feat/save-wallet-nonce-on…

e80e581

…-creation/PRF-6203

Merge pull request #444 from Cypherock/feat/save-wallet-nonce-on-crea…

1eb7daf

…tion/PRF-6203 feat(core): Handle wallet collision while creation

amanCypherock approved these changes Dec 27, 2023

View reviewed changes

ujjwal-cyph merged commit cf46bc9 into develop Dec 27, 2023
12 of 13 checks passed

ujjwal-cyph deleted the refactor/core-framework branch December 27, 2023 13:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Refactor/core framework #221

Refactor/core framework #221

ujjwal-cyph commented Apr 26, 2023 •

edited

Loading

amanCypherock commented Dec 27, 2023

Refactor/core framework #221

Refactor/core framework #221

Conversation

ujjwal-cyph commented Apr 26, 2023 • edited Loading

amanCypherock commented Dec 27, 2023

ujjwal-cyph commented Apr 26, 2023 •

edited

Loading