Increase the defined max word length to 16 to match wallet names #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The ui_list component is defined with rows size of 15 in one of its parameter. Using the component to list wallet names results in trimming of last letter of the wallet name. Fixes https://app.clickup.com/t/37308523/CHI-2010
ujjwal-cyph
commented
Sep 30, 2022
ujjwal-cyph
commented
Nov 22, 2022
The MAX_UI_LIST_WORDS will be kept same as MAX_NUMBER_OF_MNEMONIC_WORDS and MAX_UI_LIST_CHAR_LEN := MAX_MNEMONIC_WORD_LENGTH. Applications and utils use MNEMONICS macros while ui_list will use UI_LIST macros.
amanCypherock
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ui_list component is defined with rows size of 15 in one of its parameter. Using the component to list wallet names results in trimming of last letter of the wallet name.
Fixes https://app.clickup.com/t/37308523/CHI-2010