Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java] Add "CLY_" prefix to generated device id #101

Merged
merged 22 commits into from
Oct 11, 2023
+76 −75
Merged

[Java] Add "CLY_" prefix to generated device id #101

Changes from 3 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
f49ad50
feat: device id prefix
arifBurakDemiray Oct 5, 2023
b4b9ea6
refactor: move to generator
arifBurakDemiray Oct 6, 2023
c43f7ea
chore: remove unnecesary whitespace
arifBurakDemiray Oct 6, 2023
559559e
Deleting unused code blocks
ArtursKadikis Oct 9, 2023
2f6bd25
some more refactoring
ArtursKadikis Oct 9, 2023
7aa15d7
Merge pull request #105 from Countly/staging
arifBurakDemiray Oct 10, 2023
3aacbb4
fix: increase time for delay
arifBurakDemiray Oct 10, 2023
6efe15b
refactor: only wait for endAndRecord
arifBurakDemiray Oct 10, 2023
fe3cb22
feat: device id tests
arifBurakDemiray Oct 10, 2023
10a44eb
fix: wait for other one also
arifBurakDemiray Oct 10, 2023
031c1f7
fix: no wait sync
arifBurakDemiray Oct 10, 2023
4566837
fix: wait for id get
arifBurakDemiray Oct 10, 2023
5c01371
feat: thread yield to wait
arifBurakDemiray Oct 10, 2023
343e384
fix: null check to delete files
arifBurakDemiray Oct 10, 2023
c4505a5
fix: wait for device id generation
arifBurakDemiray Oct 10, 2023
018e1d2
fix: manual wait for device id generation
arifBurakDemiray Oct 10, 2023
d9d4d1d
fix: do not sync
arifBurakDemiray Oct 10, 2023
9c64f5c
fix: wait issues
arifBurakDemiray Oct 10, 2023
810dafe
fix: sycn with instance
arifBurakDemiray Oct 10, 2023
3382684
refactoring device ID test
ArtursKadikis Oct 11, 2023
359b5a8
reverting the timed test
ArtursKadikis Oct 11, 2023
ded6a30
moving the sleep
ArtursKadikis Oct 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions sdk-java/src/main/java/ly/count/sdk/java/internal/ModuleDeviceIdCore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
import java.util.Map;
import java.util.UUID;
import java.util.concurrent.Future;

import ly.count.sdk.java.Config;

/**
Expand All @@ -24,14 +23,17 @@ public class ModuleDeviceIdCore extends ModuleBase {
private Tasks tasks;

private static final class UUIDGenerator implements DeviceIdGenerator {

private final static String DEVICE_ID_PREFIX = "CLY_";

@Override
public boolean isAvailable() {
return true;
}

@Override
public String generate(CtxCore context) {
return UUID.randomUUID().toString();
return DEVICE_ID_PREFIX + UUID.randomUUID();
}
}

Expand Down