Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java] Add "CLY_" prefix to generated device id #101

Merged
merged 22 commits into from
Oct 11, 2023
Merged

[Java] Add "CLY_" prefix to generated device id #101

merged 22 commits into from
Oct 11, 2023

Conversation

arifBurakDemiray
Copy link
Member

No description provided.

@github-actions
Copy link

github-actions bot commented Oct 6, 2023 •
edited
Loading

Unit Test Results 🚀

215 tests  +2   214 ✔️ +2   9s ⏱️ -1s
  20 suites +1       0 💤 ±0 
  20 files   +1       1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 359b5a8. ± Comparison against base commit d9ebb5c.

♻️ This comment has been updated with latest results.

@arifBurakDemiray arifBurakDemiray marked this pull request as ready for review October 6, 2023 14:09
ArtursKadikis
ArtursKadikis requested changes Oct 9, 2023
View reviewed changes
Copy link
Member

@ArtursKadikis ArtursKadikis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add some tests. Create the file "DeviceIDModuleTests".
one test where we init with no device ID provided, that id should have the prefix
one test where we provide a custom device id, there is no prefix

@ArtursKadikis ArtursKadikis merged commit f22f989 into staging Oct 11, 2023
@ArtursKadikis ArtursKadikis deleted the cly_prefix_device_id branch October 11, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArtursKadikis ArtursKadikis ArtursKadikis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arifBurakDemiray @ArtursKadikis