-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Electra ref-test alpha.9 update #8882
Electra ref-test alpha.9 update #8882
Conversation
583a6c4
to
f2bdbeb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This was a recent change by the way.
Included in the alpha.9 release two weeks ago:
I suspect the reference tests are failing because Teku is using alpha.8 right now.
Also, the fact that you missed this was my fault. I missed including it in the release notes. See: |
Correct. I'm working on the update to alpha9! |
d18bb39
to
afe7063
Compare
PR Description
This PR has 3 fixes:
Also, we are adding one reference test to the ignore list
invalid_nonset_bits_for_one_committee
to be fixed in a separate issue (#8892).Another thing is we disabled
fuzzConsolidationRequest_minimal
onFuzzUtilTest
. We will look at fixing it as part of #8876Electra state upgrade
I found an issue with our calculation while running the latest reference tests. We were not taking into consideration when:
earliest_exit_epoch = compute_activation_exit_epoch(get_current_epoch(pre))
is greater than the max exitEpoch from our validator set.The current change should match this:
Spec Reference: https://github.com/ethereum/consensus-specs/blob/dev/specs/electra/fork.md#upgrading-the-state
Pending partial withdrawals
Add missed exit checks to consolidation processing
Documentation
doc-change-required
label to this PR if updates are required.Changelog