EIP-7251 Add missed exit checks to consolidation processing #8860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mehdi-aouadi
reviewed
Dec 2, 2024
There was a problem hiding this comment.
The changes LGTM
Yet need to fix the failing ref tests. It looks like you need the new SingleAttestation changes. I'd suggest rebasing your branch on top of master since the new container has been added there and see how it goes (That would fix the ssz related ones at least)
StefanBratanov
force-pushed
the
missed_exit_checks
branch
from
9b155a7 to
1af8a1e
Compare
StefanBratanov
force-pushed
the
missed_exit_checks
branch
from
1af8a1e to
b74afe1
Compare
|
I have a PR with all fixes for alpha.9. I have incorporated these changes there: #8882 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
As per ethereum/consensus-specs#4000
Fixed Issue(s)
fixes #8801
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog