-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify blob sidecar availability checker #8840
Simplify blob sidecar availability checker #8840
Conversation
...ence-tests/src/referenceTest/java/tech/pegasys/teku/reference/ManualReferenceTestRunner.java
Outdated
Show resolved
Hide resolved
...ec/src/main/java/tech/pegasys/teku/spec/datastructures/blobs/versions/deneb/BlobSidecar.java
Show resolved
Hide resolved
.../tech/pegasys/teku/statetransition/forkchoice/ForkChoiceBlobSidecarsAvailabilityChecker.java
Outdated
Show resolved
Hide resolved
since i forgot to do this marking i think the way I did it is a bit error prone. I'll change it. |
I will join Mehdi feedback:
|
0cfe5bb
to
39ecb99
Compare
39ecb99
to
e3a2ee7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have not checked tests, yet (starting)
beacon/sync/src/main/java/tech/pegasys/teku/beacon/sync/historical/HistoricalBatchFetcher.java
Outdated
Show resolved
Hide resolved
beacon/sync/src/main/java/tech/pegasys/teku/beacon/sync/historical/HistoricalBatchFetcher.java
Show resolved
Hide resolved
...ec/src/main/java/tech/pegasys/teku/spec/datastructures/blobs/versions/deneb/BlobSidecar.java
Show resolved
Hide resolved
...spec/src/main/java/tech/pegasys/teku/spec/logic/versions/deneb/helpers/MiscHelpersDeneb.java
Show resolved
Hide resolved
.../tech/pegasys/teku/statetransition/forkchoice/ForkChoiceBlobSidecarsAvailabilityChecker.java
Outdated
Show resolved
Hide resolved
.../tech/pegasys/teku/statetransition/forkchoice/ForkChoiceBlobSidecarsAvailabilityChecker.java
Show resolved
Hide resolved
66accfa
to
e6e7d27
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
LGTM
Worth run on some test nodes before merging into master.
...transition/src/main/java/tech/pegasys/teku/statetransition/blobs/BlobSidecarManagerImpl.java
Outdated
Show resolved
Hide resolved
I run an historical sync test (mainnet) , I'll run more tests (mainnet and local) |
@zilm13 take a look to latest commit. Testing session was fine, historical sync, forward symc, chain follow. |
@tbenr loooks good, the only nit, it maybe better to mark it as validated in |
blobs get from EL are marked as valid (trust assumption on EL)
fixes #8740
Documentation
doc-change-required
label to this PR if updates are required.Changelog