Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify blob sidecar availability checker #8840

Merged
merged 32 commits into from
Dec 16, 2024

Conversation

tbenr
Copy link
Contributor

@tbenr tbenr commented Nov 20, 2024

blobs get from EL are marked as valid (trust assumption on EL)

fixes #8740

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@tbenr
Copy link
Contributor Author

tbenr commented Nov 22, 2024

since i forgot to do this marking i think the way I did it is a bit error prone. I'll change it.

@zilm13
Copy link
Contributor

zilm13 commented Nov 24, 2024

I will join Mehdi feedback:

  • if some validation was not performed I expect that we want to run it now
  • if it means that it was actually performed but failed it's confusing
  • I'm not sure on extending base BlobSidecar class, maybe better make some wrapper? It would be cleaner.
  • I'm happy with split kzg+inclusion / signature

@tbenr tbenr force-pushed the simplify-BlobSidecarAvailabilityChecker branch 3 times, most recently from 0cfe5bb to 39ecb99 Compare November 26, 2024 14:43
@tbenr tbenr force-pushed the simplify-BlobSidecarAvailabilityChecker branch from 39ecb99 to e3a2ee7 Compare December 9, 2024 16:37
Copy link
Contributor

@zilm13 zilm13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have not checked tests, yet (starting)

@tbenr tbenr force-pushed the simplify-BlobSidecarAvailabilityChecker branch from 66accfa to e6e7d27 Compare December 13, 2024 12:03
@tbenr tbenr marked this pull request as ready for review December 13, 2024 13:49
Copy link
Contributor

@zilm13 zilm13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
LGTM
Worth run on some test nodes before merging into master.

@tbenr
Copy link
Contributor Author

tbenr commented Dec 13, 2024

Worth run on some test nodes before merging into master.

I run an historical sync test (mainnet) , I'll run more tests (mainnet and local)

@tbenr
Copy link
Contributor Author

tbenr commented Dec 13, 2024

I actually forgot this:
image

discovered during tests :)

@tbenr
Copy link
Contributor Author

tbenr commented Dec 13, 2024

@zilm13 take a look to latest commit. Testing session was fine, historical sync, forward symc, chain follow.

@zilm13
Copy link
Contributor

zilm13 commented Dec 16, 2024

@tbenr loooks good, the only nit, it maybe better to mark it as validated in if, by to your decision.

@tbenr tbenr enabled auto-merge (squash) December 16, 2024 09:44
@tbenr tbenr merged commit b832b91 into Consensys:master Dec 16, 2024
17 checks passed
@tbenr tbenr deleted the simplify-BlobSidecarAvailabilityChecker branch December 16, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Simplify blobSidecar availability checker
3 participants