complete deneb mischelper tests

Consensys · Dec 13, 2024 · e6e7d27 · e6e7d27
1 parent 0c6da5a
commit e6e7d27
Showing 1 changed file with 26 additions and 23 deletions.
diff --git a/...c/test/java/tech/pegasys/teku/spec/logic/versions/deneb/helpers/MiscHelpersDenebTest.java b/...c/test/java/tech/pegasys/teku/spec/logic/versions/deneb/helpers/MiscHelpersDenebTest.java
@@ -73,33 +73,33 @@ public void versionedHash() {
   void verifyBlobSidecarCompleteness_shouldThrowWhenSizesDoNotMatch() {
     assertThatThrownBy(
             () ->
-                    miscHelpersDeneb.verifyBlobSidecarCompleteness(
-                            dataStructureUtil.randomBlobSidecars(1),
-                            dataStructureUtil.randomSignedBeaconBlockWithCommitments(2)))
-            .isInstanceOf(IllegalArgumentException.class)
-            .hasMessage("Blob sidecars are not complete");
+                miscHelpersDeneb.verifyBlobSidecarCompleteness(
+                    dataStructureUtil.randomBlobSidecars(1),
+                    dataStructureUtil.randomSignedBeaconBlockWithCommitments(2)))
+        .isInstanceOf(IllegalArgumentException.class)
+        .hasMessage("Blob sidecars are not complete");
   }
 
   @Test
   void verifyBlobSidecarCompleteness_shouldThrowWhenBlobSidecarIndexIsWrong() {
     final List<BlobSidecar> blobSidecars = dataStructureUtil.randomBlobSidecars(1);
     assertThatThrownBy(
             () ->
-                    miscHelpersDeneb.verifyBlobSidecarCompleteness(
-                            blobSidecars, dataStructureUtil.randomSignedBeaconBlockWithCommitments(1)))
-            .isInstanceOf(IllegalArgumentException.class)
-            .hasMessage(
-                    "Blob sidecar index mismatch, expected 0, got %s", blobSidecars.getFirst().getIndex());
+                miscHelpersDeneb.verifyBlobSidecarCompleteness(
+                    blobSidecars, dataStructureUtil.randomSignedBeaconBlockWithCommitments(1)))
+        .isInstanceOf(IllegalArgumentException.class)
+        .hasMessage(
+            "Blob sidecar index mismatch, expected 0, got %s", blobSidecars.getFirst().getIndex());
   }
 
   @Test
   void verifyBlobSidecarCompleteness_shouldNotThrow() {
     final SignedBeaconBlock block = dataStructureUtil.randomSignedBeaconBlockWithCommitments(2);
-    final List<BlobSidecar> blobSidecars = List.of(dataStructureUtil.randomBlobSidecarForBlock(block, 0), dataStructureUtil.randomBlobSidecarForBlock(block, 1));
-    assertDoesNotThrow(
-            () ->
-                    miscHelpersDeneb.verifyBlobSidecarCompleteness(
-                            blobSidecars, block));
+    final List<BlobSidecar> blobSidecars =
+        List.of(
+            dataStructureUtil.randomBlobSidecarForBlock(block, 0),
+            dataStructureUtil.randomBlobSidecarForBlock(block, 1));
+    assertDoesNotThrow(() -> miscHelpersDeneb.verifyBlobSidecarCompleteness(blobSidecars, block));
   }
 
   @Test
@@ -183,8 +183,7 @@ void verifyBlobKzgCommitmentInclusionProofShouldValidate() {
               .kzgCommitmentInclusionProof(merkleProof)
               .build();
       assertThat(miscHelpersDeneb.verifyBlobKzgCommitmentInclusionProof(blobSidecar)).isTrue();
-assertThat(blobSidecar.isKzgCommitmentInclusionProofValidated()).isTrue();
-
+      assertThat(blobSidecar.isKzgCommitmentInclusionProofValidated()).isTrue();
 
       // And the same blobSidecar but with wrong merkle proof
       for (int j = 0; j < numberOfCommitments; ++j) {
@@ -220,24 +219,28 @@ void verifyBlobKzgCommitmentInclusionProofShouldValidate() {
     }
   }
 
-
   @Test
   void verifyBlobSidecarBlockHeaderSignatureViaValidatedSignedBlock_returnsTrue() {
     final SignedBeaconBlock signedBeaconBlock =
         dataStructureUtil.randomSignedBeaconBlockWithCommitments(1);
     final BlobSidecar blobSidecar =
         dataStructureUtil.randomBlobSidecarForBlock(signedBeaconBlock, 0);
-    assertThat(miscHelpersDeneb.verifyBlobSidecarBlockHeaderSignatureViaValidatedSignedBlock(blobSidecar, signedBeaconBlock)).isTrue();
+    assertThat(
+            miscHelpersDeneb.verifyBlobSidecarBlockHeaderSignatureViaValidatedSignedBlock(
+                blobSidecar, signedBeaconBlock))
+        .isTrue();
     assertThat(blobSidecar.isSignatureValidated()).isTrue();
   }
 
   @Test
   void verifyBlobSidecarBlockHeaderSignatureViaValidatedSignedBlock_returnsFalse() {
     final SignedBeaconBlock signedBeaconBlock =
-            dataStructureUtil.randomSignedBeaconBlockWithCommitments(1);
-    final BlobSidecar blobSidecar =
-            dataStructureUtil.randomBlobSidecar();
-    assertThat(miscHelpersDeneb.verifyBlobSidecarBlockHeaderSignatureViaValidatedSignedBlock(blobSidecar, signedBeaconBlock)).isFalse();
+        dataStructureUtil.randomSignedBeaconBlockWithCommitments(1);
+    final BlobSidecar blobSidecar = dataStructureUtil.randomBlobSidecar();
+    assertThat(
+            miscHelpersDeneb.verifyBlobSidecarBlockHeaderSignatureViaValidatedSignedBlock(
+                blobSidecar, signedBeaconBlock))
+        .isFalse();
     assertThat(blobSidecar.isSignatureValidated()).isFalse();
   }
 }