fix: Include automatic deployment feature on executeTxn for get-starknet in release/2.3.0 #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: add webpack.config.dev.js for local serving of remoteEntry.js * chore: lint and optional env variable for SNAP_ID * fix: update get-starknet/webpack-dev-server dep to address security vulnerability * fix: remoteEntry.js serving done on static file from dist/webpack folder * chore: added .env.sample example file * feat: optional PUBLIC_PATH env variable to produce local remoteEntry.js * chore: updated README.md * fix: env variable for local environment resolved at build time * fix: check and deploy on executeTxn * fix: isAccountDeployed requires publicKey * feat: add waiting mode for create account * feat: wait for tx in executTxn if account not deployed * test: adapted executeTxn tests to account for accountDeployment feature * style: prettier * style: lint * fix: waitForDeployment * test: fix executeTxn * fix: lint * fix: add waitForTransaction to maximize chance of success * fix: snap.manifest.json endowment:rpc * fix: uses estimateFeeBulk directly * style: remove console.log * test: executeTxn tests with account deployed or not * test: improve coverage and readability * test: rollback to match MM style --------- Co-authored-by: stanleyyuen <[email protected]>
khanti42
requested review from
Julink-eth and
wantedsystem
and removed request for
a team
khanti42
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.