feat: show upgrade dialog on get-starknet calls #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: change account contract to cairo 1 - update recover account to return correct address - update create account to use isAccountAddressDeployed method - update est gas fee to use new accountClassHash - add upgradeRequired in to acc object - fix test case * fix: update incorrect name --------- Co-authored-by: Amine Harty <[email protected]>
* feat: change account contract to cairo 1 - update recover account to return correct address - update create account to use isAccountAddressDeployed method - update est gas fee to use new accountClassHash - add upgradeRequired in to acc object - fix test case * feat: add blocking on snap method - add blocking on snap methods - add test case * fix: update incorrect name * fix: lint style * fix: bug in merge conflict * fix: update yarn lock
Bumps [word-wrap](https://github.com/jonschlinkert/word-wrap) from 1.2.3 to 1.2.5. - [Release notes](https://github.com/jonschlinkert/word-wrap/releases) - [Commits](jonschlinkert/word-wrap@1.2.3...1.2.5) --- updated-dependencies: - dependency-name: word-wrap dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [@adobe/css-tools](https://github.com/adobe/css-tools) from 4.2.0 to 4.3.1. - [Changelog](https://github.com/adobe/css-tools/blob/main/History.md) - [Commits](https://github.com/adobe/css-tools/commits) --- updated-dependencies: - dependency-name: "@adobe/css-tools" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [semver](https://github.com/npm/node-semver) from 7.3.8 to 7.5.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md) - [Commits](npm/node-semver@v7.3.8...v7.5.2) --- updated-dependencies: - dependency-name: semver dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* fix: recoverAccount to avoid duplicate called on isUpgradeRequired
* chore: hardcode cairo version 1 to constant CAIRO_VERSION
* fix: findAddressIndex should return address if the address match either cairo0 or cairo{N}
* fix: getCorrectContractAddress, use getVersion instead of getOwner to determine account has deployed or not
* chore: getCorrectContractAddress to return upgrade required attribute
* fix: fix the get correct account method * feat: add cairo upgrade api * fix: rollback package.json * fix: est fee in upgrade contract
|
I already merged latest changes from main (including the deployment check for executeTxn), but the PR #254 including these changes in release/2.3.0 is still open. |
|
|
stanleyyconsensys
approved these changes
Jun 21, 2024
Merged
4 tasks
This was referenced Nov 26, 2024
Closed
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add upgrade dialog on below APIs where those are using by get-starknet:
starkNet_signDeclareTransactionstarkNet_signDeployAccountTransactionstarkNet_executeTxnstarkNet_declareContractif above APIS trigger with an Cairo 0, account contract, it will first display an dialog, then reject the request by throw an Error