Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/revise GitHub docker cache images #584

Open
wants to merge 34 commits into
base: main
Choose a base branch
from

Conversation

jonesho
Copy link
Contributor

@jonesho jonesho commented Jan 21, 2025

This PR implements issue(s) #589

  • It fixes and refactors the uses of actions/cache for caching pulled docker images, previously the reload of cached docker images was missing and save cache jobs would run twice (both in coordinator-testing and staterecovery-testing )
  • Due to performance issue, temporarily disables the caching for pulled docker images in our pipeline (see comment)

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@jonesho jonesho marked this pull request as draft January 21, 2025 10:55
@jonesho jonesho had a problem deploying to docker-build-and-e2e January 21, 2025 10:56 — with GitHub Actions Error
@jonesho jonesho temporarily deployed to docker-build-and-e2e January 21, 2025 11:08 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.63%. Comparing base (869bcdc) to head (284d38f).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #584      +/-   ##
============================================
- Coverage     68.97%   66.63%   -2.35%     
  Complexity     1186     1186              
============================================
  Files           327      292      -35     
  Lines         13160    12201     -959     
  Branches       1317     1088     -229     
============================================
- Hits           9077     8130     -947     
+ Misses         3533     3521      -12     
  Partials        550      550              
Flag Coverage Δ
hardhat ?
kotlin 66.63% <ø> (ø)

see 35 files with indirect coverage changes

@jonesho jonesho temporarily deployed to docker-build-and-e2e January 21, 2025 12:37 — with GitHub Actions Inactive
@jonesho jonesho temporarily deployed to docker-build-and-e2e January 21, 2025 13:28 — with GitHub Actions Inactive
@jonesho jonesho temporarily deployed to docker-build-and-e2e January 21, 2025 14:24 — with GitHub Actions Inactive
@jonesho jonesho had a problem deploying to docker-build-and-e2e January 21, 2025 15:31 — with GitHub Actions Error
@jonesho jonesho temporarily deployed to docker-build-and-e2e January 21, 2025 15:39 — with GitHub Actions Inactive
@jonesho jonesho had a problem deploying to docker-build-and-e2e January 21, 2025 16:00 — with GitHub Actions Error
@jonesho jonesho had a problem deploying to docker-build-and-e2e January 21, 2025 18:24 — with GitHub Actions Error
@jonesho jonesho had a problem deploying to docker-build-and-e2e January 21, 2025 19:30 — with GitHub Actions Error
@jonesho jonesho had a problem deploying to docker-build-and-e2e January 22, 2025 04:11 — with GitHub Actions Error
@jonesho jonesho had a problem deploying to docker-build-and-e2e January 22, 2025 05:30 — with GitHub Actions Error
@jonesho jonesho had a problem deploying to docker-build-and-e2e January 22, 2025 05:53 — with GitHub Actions Error
@jonesho jonesho had a problem deploying to docker-build-and-e2e January 22, 2025 06:15 — with GitHub Actions Error
@jonesho jonesho had a problem deploying to docker-build-and-e2e January 22, 2025 06:26 — with GitHub Actions Error
@jonesho jonesho temporarily deployed to docker-build-and-e2e January 22, 2025 06:43 — with GitHub Actions Inactive
@jonesho jonesho had a problem deploying to docker-build-and-e2e January 22, 2025 07:34 — with GitHub Actions Error
@jonesho jonesho had a problem deploying to docker-build-and-e2e January 22, 2025 08:04 — with GitHub Actions Error
@jonesho jonesho had a problem deploying to docker-build-and-e2e January 22, 2025 08:20 — with GitHub Actions Error
@jonesho jonesho temporarily deployed to docker-build-and-e2e January 22, 2025 08:28 — with GitHub Actions Inactive
@jonesho jonesho force-pushed the feat/revise-github-docker-cache-images branch from a3fdf0e to 97765c3 Compare January 22, 2025 09:08
@jonesho jonesho had a problem deploying to docker-build-and-e2e January 22, 2025 09:09 — with GitHub Actions Error
@jonesho jonesho had a problem deploying to docker-build-and-e2e January 22, 2025 09:27 — with GitHub Actions Error
@jonesho jonesho had a problem deploying to docker-build-and-e2e January 22, 2025 09:41 — with GitHub Actions Error
@jonesho jonesho had a problem deploying to docker-build-and-e2e January 22, 2025 09:47 — with GitHub Actions Error
@jonesho jonesho temporarily deployed to docker-build-and-e2e January 22, 2025 09:50 — with GitHub Actions Inactive
@jonesho jonesho self-assigned this Jan 22, 2025
@jonesho jonesho requested a review from VGau January 22, 2025 09:57
@jonesho jonesho force-pushed the feat/revise-github-docker-cache-images branch from a96ea0a to 2b10d35 Compare January 24, 2025 17:57
@jonesho jonesho had a problem deploying to docker-build-and-e2e January 24, 2025 17:58 — with GitHub Actions Error
@jonesho jonesho temporarily deployed to docker-build-and-e2e January 24, 2025 18:02 — with GitHub Actions Inactive
@jonesho jonesho requested a review from kyzooghost January 24, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants