feat: add more detailed comments

Consensys · Jan 24, 2025 · 2b10d35 · 2b10d35
1 parent 96a7a26
commit 2b10d35
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/.github/workflows/coordinator-testing.yml b/.github/workflows/coordinator-testing.yml
@@ -37,7 +37,8 @@ jobs:
         # Configure Gradle for optimal use in GiHub Actions, including caching of downloaded dependencies.
         # See: https://github.com/gradle/actions/blob/main/setup-gradle/README.md
         uses: gradle/actions/setup-gradle@cc4fc85e6b35bafd578d5ffbc76a5518407e1af0 #v4.2.1
-      # Disable cache for pulling docker images
+      # Disable cache for pulling docker images as empirically found that this 
+      # (retrieving cache and loading docker images) actually increased test time-to-completion
       # - name: Restore cached images
       #   id: restore-cached-images
       #   uses: ./.github/actions/restore-docker-images

diff --git a/.github/workflows/reuse-run-e2e-tests.yml b/.github/workflows/reuse-run-e2e-tests.yml
@@ -97,7 +97,8 @@ jobs:
         run: |
           mkdir -p tmp/local/traces/v2/conflated
           chmod -R a+w tmp/local/traces/v2/conflated
-      # Disable cache for pulling docker images
+      # Disable cache for pulling docker images as empirically found that this 
+      # (retrieving cache and loading docker images) actually increased test time-to-completion
       # - name: Restore cached images
       #   id: restore-cached-images
       #   uses: ./.github/actions/restore-docker-images

diff --git a/.github/workflows/staterecovery-testing.yml b/.github/workflows/staterecovery-testing.yml
@@ -37,7 +37,8 @@ jobs:
         # Configure Gradle for optimal use in GiHub Actions, including caching of downloaded dependencies.
         # See: https://github.com/gradle/actions/blob/main/setup-gradle/README.md
         uses: gradle/actions/setup-gradle@cc4fc85e6b35bafd578d5ffbc76a5518407e1af0 #v4.2.1
-      # Disable cache for pulling docker images
+      # Disable cache for pulling docker images as empirically found that this 
+      # (retrieving cache and loading docker images) actually increased test time-to-completion
       # - name: Restore cached images
       #   id: restore-cached-images
       #   uses: ./.github/actions/restore-docker-images

diff --git a/.github/workflows/testing.yml b/.github/workflows/testing.yml
@@ -26,7 +26,8 @@ on:
         type: string
 
 jobs:
-  # Disable cache for pulling docker images
+  # Disable cache for pulling docker images as empirically found that this 
+  # (retrieving cache and loading docker images) actually increased test time-to-completion
   # cache-docker-images:
   #   uses: ./.github/workflows/cache-docker-images.yml
   #   secrets: inherit