chore(contracts): Add tests to cover the bulkRevoke function in Abstr…

…actPortal and AbstractPortalV2
Consensys · Nov 26, 2024 · 20e3bbe · 20e3bbe
1 parent 7f57adb
commit 20e3bbe
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 0 deletions.
diff --git a/contracts/test/DefaultPortal.t.sol b/contracts/test/DefaultPortal.t.sol
@@ -323,6 +323,17 @@ contract DefaultPortalTest is Test {
     defaultPortal.bulkRevoke(attestationsToRevoke);
   }
 
+  function test_bulkRevoke_OnlyOwner() public {
+    bytes32[] memory attestationsToRevoke = new bytes32[](2);
+    attestationsToRevoke[0] = bytes32("1");
+    attestationsToRevoke[1] = bytes32("2");
+
+    // Revoke the attestation as a random user
+    vm.prank(makeAddr("random"));
+    vm.expectRevert(AbstractPortal.OnlyPortalOwner.selector);
+    defaultPortal.bulkRevoke(attestationsToRevoke);
+  }
+
   function test_supportsInterface() public view {
     bool isIERC165Supported = defaultPortal.supportsInterface(type(ERC165Upgradeable).interfaceId);
     assertEq(isIERC165Supported, true);

diff --git a/contracts/test/DefaultPortalV2.t.sol b/contracts/test/DefaultPortalV2.t.sol
@@ -243,6 +243,17 @@ contract DefaultPortalV2Test is Test {
     defaultPortal.bulkRevoke(attestationsToRevoke);
   }
 
+  function test_bulkRevoke_OnlyOwner() public {
+    bytes32[] memory attestationsToRevoke = new bytes32[](2);
+    attestationsToRevoke[0] = bytes32("1");
+    attestationsToRevoke[1] = bytes32("2");
+
+    // Revoke the attestation as a random user
+    vm.prank(makeAddr("random"));
+    vm.expectRevert(AbstractPortalV2.OnlyPortalOwner.selector);
+    defaultPortal.bulkRevoke(attestationsToRevoke);
+  }
+
   function test_supportsInterface() public view {
     bool isIERC165Supported = defaultPortal.supportsInterface(type(ERC165Upgradeable).interfaceId);
     assertEq(isIERC165Supported, true);