chore(contracts): The getAttester function should only be accessible …

…internally (#827)
Consensys · Nov 26, 2024 · 7f57adb · 7f57adb
1 parent eac2e44
commit 7f57adb
Show file tree

Hide file tree

Showing 5 changed files with 2 additions and 331 deletions.
diff --git a/contracts/src/abstracts/AbstractPortal.sol b/contracts/src/abstracts/AbstractPortal.sol
@@ -270,7 +270,7 @@ abstract contract AbstractPortal is IPortal {
    * @notice Defines the address of the entity issuing attestations to the subject
    * @dev We strongly encourage a reflection when overriding this rule: who should be set as the attester?
    */
-  function getAttester() public view virtual returns (address) {
+  function getAttester() internal view virtual returns (address) {
     return msg.sender;
   }
 

diff --git a/contracts/src/abstracts/AbstractPortalV2.sol b/contracts/src/abstracts/AbstractPortalV2.sol
@@ -202,7 +202,7 @@ abstract contract AbstractPortalV2 is IPortal {
    * @notice Defines the address of the entity issuing attestations to the subject
    * @dev We strongly encourage a reflection when overriding this rule: who should be set as the attester?
    */
-  function getAttester() public view virtual returns (address) {
+  function getAttester() internal view virtual returns (address) {
     return msg.sender;
   }
 

diff --git a/contracts/src/interfaces/IPortal.sol b/contracts/src/interfaces/IPortal.sol
@@ -16,10 +16,4 @@ interface IPortal is IERC165 {
    * @return The list of modules addresses linked to the Portal
    */
   function getModules() external view returns (address[] memory);
-
-  /**
-   * @notice Defines the address of the entity issuing attestations to the subject
-   * @dev We strongly encourage a reflection when implementing this method
-   */
-  function getAttester() external view returns (address);
 }
diff --git a/contracts/src/stdlib/IndexerModule.sol b/contracts/src/stdlib/IndexerModule.sol
diff --git a/contracts/test/stdlib/IndexerModule.t.sol b/contracts/test/stdlib/IndexerModule.t.sol