Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify write_collapsed_GFF_with_CDS in sqanti3_qc.py #331

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sbresnahan
Copy link

Suggestion to modify if ...:break statements in write_collapsed_GFF_with_CDS which compare interval start and end coordinates to ensure calls to Interval() do not throw AssertionError: start must be less than end. Current statements do not necessarily ensure that values given to Interval() are appropriate, for example, if exon coordinates are outside the predicted CDS start and end coordinates.

Context: running SQANTI3 with GTF produced by bambu was exiting with this error after classifying isoforms:

Traceback (most recent call last):
  File "sqanti3_qc.py", line 2578, in <module>
    main()
  File "sqanti3_qc.py", line 2561, in main
    run(args)
  File "sqanti3_qc.py", line 1880, in run
    write_collapsed_GFF_with_CDS(isoforms_info, corrGTF, corrGTF+'.cds.gff')
  File "sqanti3_qc.py", line 420, in write_collapsed_GFF_with_CDS
    r.cds_exons = [Interval(s, min(e,exon.end))]
                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "lib/bx/intervals/intersection.pyx", line 293, in bx.intervals.intersection.Interval.__init__
AssertionError: start must be less than end

Modify if statements comparing proposed interval start and end coordinates to ensure calls to `Interval()` do not cause `AssertionError: start must be less than end`. Previous `if:break` statements do not ensure values given to `Interval()` are appropriate.
@Fabian-RY Fabian-RY self-requested a review September 25, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant