Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote manager operations #33

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Remote manager operations #33

wants to merge 14 commits into from

Conversation

anaion
Copy link
Contributor

@anaion anaion commented Jun 2, 2014

This is a work in progress implementation to add support for the managers to spawn agents without accessing the libcloud interface, but using the director. The API for handling requests on the server's side contains now only the functions for creating and deleting a node (this is where the interface for the nested cloud will be integrated).

There are still many harcoded configuration settings (urls, paths). If you want to test, please grep for TODOs in the committed files.

@gtato
Copy link
Contributor

gtato commented Jun 4, 2014

Could any of you guys re-explain me what was the problem with reservation timers?

Some comments:
I statically reviewed ee959cd and I think it is generally okay. However it requires a bit or reorganization while merging it. For example I think the ProxyController should be merged with Controller because currently it is just a wrapper around it. Additionally the nestedapi methods should be added to the director page (maybe the service.py) while AgentController can go together with ManagerController in cloud.py.

Generally I think that the impact of merging this part of code is quite small however I also think that quite some testing is required. I have got the impression that everyone is quite busy and there are still other issues to fix. For this reason I would give it a high priority to the integration of this part right after the release but not before.

@tschuett tschuett closed this Jul 10, 2014
@gpierre42 gpierre42 reopened this Jul 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants