Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code review request: review Ana's code for Remote manager operations #34

Closed
gpierre42 opened this issue Jun 3, 2014 · 1 comment
Closed

Comments

@gpierre42
Copy link
Contributor

This is a request to take a look at @anaion 's code for remote manager operations (pull request #33). If the code is judged stable enough and it doesn't disturb the rest of the system then we can add it to the 1.4.1 release. Otherwise we will postpone to 1.5.0.


Comments from @anaion :
This is a work in progress implementation to add support for the managers to spawn agents without accessing the libcloud interface, but using the director. The API for handling requests on the server's side contains now only the functions for creating and deleting a node (this is where the interface for the nested cloud will be integrated).

There are still many harcoded configuration settings (urls, paths). If you want to test, please grep for TODOs in the committed files.

This is work in progress so there are many sketchy parts (to be read harcoded). That also means there are enough chances for improvement, so please, feel free to come up with suggestions and comments.

The nestedapi.py will include the full interface to be used by the nested architecture.
For now, only node addition and deletion are implemented.

@gpierre42
Copy link
Contributor Author

Looks like there was already an issue about this in the system. I flag this one as duplicate...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants