Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Red Hat Konflux update compliance-operator-must-gather #628

Merged
merged 2 commits into from
Dec 11, 2024
Merged

Red Hat Konflux update compliance-operator-must-gather #628

merged 2 commits into from
Dec 11, 2024

Conversation

red-hat-konflux[bot]
Copy link

Pipelines as Code configuration proposal

To start the PipelineRun, add a new comment with content /ok-to-test

For more detailed information about running a PipelineRun, please refer to Pipelines as Code documentation Running the PipelineRun

To customize the proposed PipelineRuns after merge, please refer to Build Pipeline customization

@openshift-ci openshift-ci bot requested review from jhrozek and xiaojiey November 27, 2024 19:39
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Nov 27, 2024

Hi @red-hat-konflux[bot]. Thanks for your PR.

I'm waiting for a ComplianceAsCode member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-actions GitHub Actions
Copy link

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:628-a177d76b2db993d09cc877235a5242130108d6ca

@rhmdnd rhmdnd requested review from rhmdnd and removed request for jhrozek and xiaojiey November 27, 2024 20:11
@rhmdnd rhmdnd force-pushed the appstudio-compliance-operator-must-gather branch from a177d76 to a678c26 Compare November 27, 2024 20:13
@github-actions GitHub Actions
Copy link

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:628-a678c267c2030ea1c15b776e3e9963478445fb41

@rhmdnd rhmdnd force-pushed the appstudio-compliance-operator-must-gather branch from a678c26 to a0ea604 Compare December 9, 2024 17:38
@rhmdnd rhmdnd added this to the 1.7.0 milestone Dec 9, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:628-a0ea6042d6ad6cc5c352fd3ae5dc2ae32d739261

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:628-aafc1f4810bd224ab0b06f71cf21635e29c7452c

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:628-139e60e0b957ccfafc4ae92b753a255820b05a1f

@rhmdnd rhmdnd force-pushed the appstudio-compliance-operator-must-gather branch from 64beb79 to a842ded Compare December 9, 2024 21:17
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:628-64beb7981035c9432761bbd43f434189183a127c

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:628-a842ded28306b3dadfe876b45de5c37aea4addb5

@rhmdnd rhmdnd force-pushed the appstudio-compliance-operator-must-gather branch 2 times, most recently from 393c283 to 0826e53 Compare December 9, 2024 21:28
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:628-393c28377d34bda9d1d02bc94bc6c05821128f49

@rhmdnd rhmdnd force-pushed the appstudio-compliance-operator-must-gather branch from 0826e53 to 2770b84 Compare December 9, 2024 21:32
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:628-0826e5314c48f3005b09ccb2572cc2a6e8599607

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:628-2770b84862ecf2d6046b8655cbd6301fbf6aa1b7

@rhmdnd rhmdnd force-pushed the appstudio-compliance-operator-must-gather branch from 2770b84 to 9dd5c57 Compare December 9, 2024 21:50
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:628-9dd5c57e83983c8ccf21482a026cacc74281c43c

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:628-b2285814a7a4b2e90e0d5fd0adc211eea7879a1f

@rhmdnd rhmdnd force-pushed the appstudio-compliance-operator-must-gather branch from 2706eff to 581f58f Compare December 9, 2024 22:08
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:628-2706eff9dc59c153ad5dfa3c0ed317cacdeaf4e3

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:628-581f58f8e7ab44ccbbc432557d61b45e02642aa9

@rhmdnd rhmdnd force-pushed the appstudio-compliance-operator-must-gather branch 2 times, most recently from 947ba56 to ca29679 Compare December 9, 2024 22:35
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:628-947ba56f81c979dfba767b42bab9388bea4a9f1a

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:628-ca29679bdbe8675fde58b9620bd970fb4791fc24

@rhmdnd rhmdnd force-pushed the appstudio-compliance-operator-must-gather branch from ca29679 to 1e73ec7 Compare December 9, 2024 22:48
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:628-1e73ec724edd0f87c32c9cb69f61294afec0e301

yuumasato
yuumasato requested changes Dec 10, 2024
View reviewed changes
Copy link
Member

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing the Containerfile as follows works for me:

COPY ./utils/must-gather/gather* /usr/bin/
COPY ./utils/must-gather/fetch-raw-results-pod-template.yaml /usr/share/

@rhmdnd
Update Containerfile for must-gather Konflux builds
7bcd5b0 
- Remove the subscription manager since it's not necessary with
  container builds in Konflux
- Enable RPM repository for install openshift-clients RPM which is
  necessary for must-gather functionality
- Set WORKDIR to appropriate location for Konflux source
@rhmdnd rhmdnd force-pushed the appstudio-compliance-operator-must-gather branch from 1e73ec7 to 7bcd5b0 Compare December 10, 2024 14:10
@github-actions GitHub Actions
Copy link

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:628-7bcd5b0424a02a42bf625d3c3462f7b15fd550ca

@rhmdnd rhmdnd requested a review from yuumasato December 10, 2024 14:28
@rhmdnd
Copy link

rhmdnd commented Dec 10, 2024

/ok-to-test

yuumasato
yuumasato approved these changes Dec 10, 2024
View reviewed changes
Copy link
Member

@yuumasato yuumasato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci openshift-ci bot added the lgtm label Dec 10, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: red-hat-konflux[bot], yuumasato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 10, 2024 •
edited
Loading

@red-hat-konflux[bot]: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-rosa 7bcd5b0 link true /test e2e-rosa

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rhmdnd
Copy link

rhmdnd commented Dec 10, 2024

/test e2e-aws-serial

@rhmdnd
Copy link

rhmdnd commented Dec 11, 2024

ROSA e2e failures are unrelated.

@rhmdnd rhmdnd merged commit 9bc9fc3 into master Dec 11, 2024
18 of 20 checks passed
@rhmdnd rhmdnd deleted the appstudio-compliance-operator-must-gather branch December 11, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yuumasato yuumasato yuumasato approved these changes

@rhmdnd rhmdnd Awaiting requested review from rhmdnd

Assignees

@yuumasato yuumasato

Labels
approved lgtm ok-to-test
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
2 participants
@rhmdnd @yuumasato