Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix localization issues second attempt #387

Merged
merged 6 commits into from
Apr 10, 2024
Merged

Fix localization issues second attempt #387

merged 6 commits into from
Apr 10, 2024

Conversation

CGNonofr
Copy link
Contributor

@CGNonofr CGNonofr commented Apr 9, 2024

No description provided.

@CGNonofr CGNonofr requested a review from kaisalmen April 9, 2024 22:41
@kaisalmen
Copy link
Collaborator

kaisalmen commented Apr 10, 2024 •
edited
Loading

@CGNonofr awesome, when do you sleep? I have one further request: Can you export interfaces AvailableLanguage and LocalizationOptions from @codingame/monaco-vscode-localization-service-override because this is part of the exposed getServiceOverride, but one can't import the type. I externalized the "default" function and it is nicer if it can have a specific type. Thank you.

@CGNonofr
Copy link
Contributor Author

CGNonofr commented Apr 10, 2024 •
edited
Loading

@CGNonofr awesome, when do you sleep? I have one further request: Can you export interfaces AvailableLanguage and LocalizationOptions from @codingame/monaco-vscode-localization-service-override because this is part of the exposed getServiceOverride, but one can't import the type. I externalized the "default" function and it is nicer if it can have a specific type. Thank you.

sure! 87a8fa6

(sorry for the delay, I was sleeping!)

kaisalmen
kaisalmen approved these changes Apr 10, 2024
View reviewed changes
Copy link
Collaborator

@kaisalmen kaisalmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you once more. LGTM

@CGNonofr CGNonofr merged commit cf3e9ea into main Apr 10, 2024
2 checks passed
@CGNonofr CGNonofr deleted the fix-localization-issues2 branch April 10, 2024 09:34
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 4.1.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaisalmen kaisalmen kaisalmen approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CGNonofr @kaisalmen