Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt handler to initiatives #23

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Adapt handler to initiatives #23

merged 2 commits into from
Dec 20, 2023

Conversation

laurajaime
Copy link

@laurajaime laurajaime commented Dec 20, 2023 •
edited by tramuntanal
Loading

🎩 What? Why?

Initiatives do a handler_for with document_number field but in the module, the field is named id_document.

this PR adds the :document_number attribute as a kind of synonym of id_document to keep compatibility with existing authorizations and also be compatible with decidim-initiatives.

@laurajaime laurajaime self-assigned this Dec 20, 2023
@laurajaime laurajaime mentioned this pull request Dec 20, 2023
Merged
tramuntanal
tramuntanal requested changes Dec 20, 2023
View reviewed changes
Copy link

@tramuntanal tramuntanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We must upgrade the CHANGELOG and the gem version so we can release a new version

tramuntanal
tramuntanal approved these changes Dec 20, 2023
View reviewed changes
Copy link

@tramuntanal tramuntanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @laurajaime !
good

@laurajaime laurajaime merged commit bfd04b4 into master Dec 20, 2023
2 checks passed
@laurajaime laurajaime deleted the adapt_handler branch December 20, 2023 11:02
@tramuntanal tramuntanal mentioned this pull request Mar 20, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tramuntanal tramuntanal tramuntanal approved these changes

Assignees

@laurajaime laurajaime

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laurajaime @tramuntanal