Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix document number field duplication during verification #24

Merged
merged 3 commits into from
Mar 20, 2024

Conversation

tramuntanal
Copy link

🎩 What? Why?

The changes in last version made the document number field being duplicated in the user verification form. One field was rendered for the :id_document attribute and another was rendered for the :document_number attribute. The handler was still working whichever field was set.

To avoid the field duplication this PR removes the :document_number attribute and extracts that field in the constructor if present.

Binstubs for rspec and rubocop has also been added.

📌 Related Issues

📋 Subtasks

  • Add documentation regarding the feature
  • Add tests

@tramuntanal tramuntanal requested a review from laurajaime March 20, 2024 06:22
@tramuntanal tramuntanal self-assigned this Mar 20, 2024
Copy link

@laurajaime laurajaime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good solution!

@tramuntanal tramuntanal merged commit c9acceb into master Mar 20, 2024
2 checks passed
@tramuntanal tramuntanal deleted the fix/document_number_in_handler branch March 20, 2024 07:14
@tramuntanal tramuntanal restored the fix/document_number_in_handler branch March 20, 2024 16:16
@tramuntanal tramuntanal deleted the fix/document_number_in_handler branch March 20, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants